On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley <conor(a)kernel.org> wrote:
Hey Palmer, Xianting,
On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote:
> On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote:
> > As disscussed in below patch set, the patch of 'describe VMCOREINFO export
in Documentation'
> > need to update according to Bagas's comments.
> >
https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@...
> >
> > As others patches in above patch set already applied, so this patch set only
contains below two
> > patches.
> >
> > [...]
>
> Applied, thanks!
>
> [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support
>
https://git.kernel.org/palmer/c/649d6b1019a2
So this patch seems to be causing issues for the nommu build:
https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.com/
I had a bit of a poke at trying to see if there were some headers we
could pull in before actually checking the .config only to see:
# CONFIG_MMU is not set
Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix
compilation here?
The problem does not belong to the patch.
Could I send a fixup patch? like this?
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index ef8d66de5f38..d8c07999426c 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY
config CRASH_DUMP
bool "Build kdump crash kernel"
+ depends on KEXEC
help
Generate crash dump after being started by kexec. This should
be normally only set in special crash dump kernels which are
Thanks,
Conor.
--
Best Regards
Guo Ren