Re: [Crash-utility] [RFC PATCH 15/15] mod: Change "BASE" on header to "TEXT_BASE" to clarify

On 2023/05/30 15:03, lijiang wrote: Sure. Oh, I didn't see this, thanks. char buf[80]; actually secname is 64 bytes at most, so it can overflow. Sure. Thanks, Kazu > > Thanks. > Lianbo > > mkstring(buf3, maxsizelen, RJUST, "SIZE")); >> } >> >> -- >> 2.31.1 >> >> >> >> On Thu, May 11, 2023 at 12:35 PM HAGIO KAZUHITO(萩尾　一仁) <k-hagio-ab(a)nec.com <mailto:k-hagio-ab@nec.com>> wrote: >> >> Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com <mailto:k-hagio-ab@nec.com>> >> --- >>  kernel.c | 2 +- >>  1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel.c b/kernel.c >> index 013a9a4d08f4..d6b25ddd1186 100644 >> --- a/kernel.c >> +++ b/kernel.c >> @@ -4569,7 +4569,7 @@ do_module_cmd(ulong flag, char *modref, ulong address, >>                                 "MODULE"), >>                                 mkstring(buf2, maxnamelen, LJUST, "NAME"), >>                                 mkstring(buf4, VADDR_PRLEN, CENTER|LJUST, >> -                               "BASE"), >> +                               MODULE_MEMORY() ? "TEXT_BASE" : "BASE"), >> >> >> This is a simple fix, could you please put the [patch 15/15] to [patch 01/15] together? >> >> BTW: I saw several indent issues in these patches, and also a warning as below: >> >> symtab.c: In function ‘void gdb_command_funnel_1(gnu_request*)’: >> symtab.c:7519:64: warning: ‘%lx’ directive writing between 1 and 16 bytes into a region of size between 10 and 73 [-Wformat-overflow=] >>  7519 |                                         sprintf(buf, " -s %s 0x%lx", secname, lm->mod_section_data[i].addr); >>       |                                                                ^~~ >> symtab.c:7519:54: note: directive argument in the range [1, 18446744073709551615] >>  7519 |                                         sprintf(buf, " -s %s 0x%lx", secname, lm->mod_section_data[i].addr); >>       |                                                      ^~~~~~~~~~~~~~ >> >> >> In addition, is it possible to put these fixes into their corresponding patches in the next post? I know it might be additional work, but it is very helpful for maintaining and reviewing them. >> >> Thanks. >> Lianbo >> >>                                 mkstring(buf3, maxsizelen, RJUST, "SIZE")); >>                 } >> >> -- >> 2.31.1 >>