Re: [Crash-utility] [PATCH] extensions/eppic.mk: Remove ping check to github.com
Hi, Kazu
在 2020年12月21日 14:18, crash-utility-request(a)redhat.com 写道:
Date: Mon, 21 Dec 2020 06:18:43 +0000
From: HAGIO KAZUHITO(?????) <k-hagio-ab(a)nec.com>
To: "Discussion list for crash utility usage, maintenance and
development" <crash-utility(a)redhat.com>
Cc: "lchouinard(a)s2sys.com" <lchouinard(a)s2sys.com>
Subject: [Crash-utility] [PATCH] extensions/eppic.mk: Remove ping
check to github.com
Message-ID:
<OSBPR01MB19916B18E8F90D393F3839B1DDC00(a)OSBPR01MB1991.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="iso-2022-jp"
Without this patch, in an environment where ping to github.com does
not work, building eppic.so fails with the message "eppic.so: failed
to pull eppic code from git repo" and "make clean" at the top-level
crash directory unnecessarily takes about 10 seconds every time.
$ time make clean
...
real 0m10.398s
This change is very helpful.
Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
---
extensions/eppic.mk | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/extensions/eppic.mk b/extensions/eppic.mk
index c79170a596b7..7486ce46a6b8 100644
--- a/extensions/eppic.mk
+++ b/extensions/eppic.mk
@@ -24,7 +24,6 @@ ifeq ($(TARGET), X86)
endif
APPFILE=eppic/applications/crash/eppic.c
-GITHUB := $(shell ping -c 1 github.com | grep "1 received")
BTW: Is it possible to fix this issue with the option -W? For example:
GITHUB := $(shell ping -c 1 -W 2 github.com | grep "1 received")
^^^^
Thanks.
Lianbo
GIT := $(shell which git 2> /dev/null)
all:
@@ -38,9 +37,7 @@ all:
if [ -n "$(EPPIC_GIT_URL)" ]; then \
git clone "$(EPPIC_GIT_URL)" eppic; \
else \
- if [ -n "$(GITHUB)" ] ; then \
- git clone https://github.com/lucchouina/eppic.git eppic; \
- fi; \
+ git clone https://github.com/lucchouina/eppic.git eppic; \
fi; \
else \
if [ ! -f "$(GIT)" ]; then \
-- 2.18.4