[Crash-utility] Re: [PATCH] Fix pipe parsing to correctly handle quotes

Thanks for the fix, LGTM, ack. Thanks, Tao Liu On Wed, Feb 11, 2026 at 3:54 PM neilfsun <loyou85(a)gmail.com&gt; wrote: > > When parsing command lines with pipes, the previous logic incorrectly > handled nested quote types. The string detection used a simple > boolean toggle that would flip state for ANY quote character (single or > double), causing pipes inside quoted strings to be incorrectly recognized > as command separators. Without the fix, the following commands will stuck: > > crash> help -t | awk '/panic_processor/{print "p cpu_info:"$2" | grep phys_proc_id"}' > > Signed-off-by: neilfsun <neilfsun(a)tencent.com&gt; > Signed-off-by: Feng Sun <loyou85(a)gmail.com&gt; > --- > cmdline.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/cmdline.c b/cmdline.c > index e9fe92a..43af77c 100644 > --- a/cmdline.c > +++ b/cmdline.c > @@ -486,7 +486,7 @@ setup_redirect(int origin) > char *p, which; > int append; > int expression; > - int string; > + char string; > int ret ATTRIBUTE_UNUSED; > FILE *pipe; > FILE *ofile; > @@ -506,7 +506,7 @@ setup_redirect(int origin) > pc->redirect |= REDIRECT_SHELL_COMMAND; > > expression = 0; > - string = FALSE; > + string = 0; > > while (*p) { > if (*p == '(') > @@ -514,10 +514,12 @@ setup_redirect(int origin) > if (*p == ')') > expression--; > > - if ((*p == '"') || (*p == '\'')) > - string = !string; > + if (*p == '\'' && string != '"') > + string = (string == '\'') ? 0 : '\''; > + else if (*p == '"' && string != '\'') > + string = (string == '"') ? 0 : '"'; > > - if (!(expression || string) && > + if (!(expression || string) && > ((*p == '|') || (*p == '!'))) { > which = *p; > *p = NULLCHAR; > @@ -674,16 +676,18 @@ int > multiple_pipes(char **input) > { > char *p, *found; > - int quote; > + char quote; > > found = NULL; > - quote = FALSE; > + quote = 0; > > for (p = *input; *p; p++) { > - if ((*p == '\'') || (*p == '"')) { > - quote = !quote; > - continue; > - } else if (quote) > + if (*p == '\'' && quote != '"') > + quote = (quote == '\'') ? 0 : '\''; > + else if (*p == '"' && quote != '\'') > + quote = (quote == '"') ? 0 : '"'; > + > + if (quote) > continue; > > if (*p == '|') { > -- > 2.52.0 > -- > Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io > To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io > https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ > Contribution Guidelines: https://github.com/crash-utility/crash/wiki