Re: [Crash-utility] [PATCH v4] files: support dump file memory mapping
----- Original Message -----
>
> So in the interest of expediency, what I will do is this:
>
> (1) change "files -m" to "files -c"
> (2) drop the MAPPING column from "files -p"
> (3) reword the description of the two options in the help page to emphasize
> that the NRPAGES count and page dumps are page cache counts/page-dumps
> (4) either figure out a way to compress the help page example outputs into
> 80 columns, or drop the files -p example completely
>
> I'll post the patch this afternoon and you can verify it tonight.
Sure, I will. Thanks for your helps and comments.
I hope I can do better for my next patch. :-)
Hi Oliver,
I've attached the patch for your review. In addition to the items listed
above, I also made a few other minor changes to better handle some error
conditions I ran into while testing the patch, I renamed a few functions and
macros to be more related to their actual purpose, globally exposed just the
single-page dump callback function, and made it return a legitimate return value.
(And there may be other minor changes that I can't remember.)
Let me know what you think about the changes, and if we're in agreement,
I'll check it in tomorrow.
Thanks,
Dave
Attachments:
- files_v5.patch (text/x-patch — 16.7 KB)