[Crash-utility] [RESEND] Re: [PATCH 00/12] Add sadump format support
For whatever reason, the archived version of my response was completely
screwed up:
https://www.redhat.com/archives/crash-utility/2011-September/msg00001.html
So the digest version will probably be borked as well...
This was my response:
----- Original Message -----
Hello Dave,
I'm sorry for taking considerably long time. Now I post a patch set
implementing sadump support for crash utility.
Applying this patch set, crash utility will be able to recognize
sadump-related formats on 3 kinds configurations: single partition,
diskset and media backup file.
The crash version the patch set can be applied to is 5.1.7.
Please look at each patch description for detailed explanation.
Hello Daisuke,
The patch-set looks good, and the changes to the common code are
nicely segregated.
But let's simplify things. I'd prefer to avoid all of these constructs:
if (!(pc->flags & DUMPFILE_TYPES) && !(pc->flags2 & SADUMP))
...
if ((pc->flags & MEMORY_SOURCES) || (pc->flags2 & MEMORY_SOURCES2))
...
Can you move the REMOTE_DAEMON bit from pc->flags to the next available
pc->flags2 bit, and then change these four references appropriately:
C symbol: REMOTE_DAEMON
File Function Line
0 defs.h <global> 145 #define REMOTE_DAEMON (0x200ULL)
1 defs.h REMOTE 206 #define REMOTE() (pc->flags & REMOTE_DAEMON)
2 main.c main 375 pc->flags |= REMOTE_DAEMON;
3 main.c dump_program_context 1084 if (pc->flags & REMOTE_DAEMON)
Then you can make SADUMP equal to 0x200ULL, and put it in pc->flags,
DUMPFILE_TYPES and MEMORY_SOURCES. That will signficantly simplify
the patch-set.
BTW, do you want sadump dumpfiles? I geuss you need them for testing
samples.
Definitely -- but please make them as small as possible, and you can
send me the dumpfile-access details privately if you prefer.
Depending upon how quickly you can create an updated patchset, I may defer
this to crash-5.1.9 because I'm just about to release 5.1.8.
Thanks,
Dave