Re: [Crash-utility] [PATCH V3] Add -C option for search
----- Original Message -----
----- Original Message -----
> Hello Dave,
>
> The new patch is attached.
>
> I simplified the display_with_pre_and_post() function by calling the
> currently-existing display_memory() function, and made the output
> readable according to your advice.
>
> Thanks
> Zhang Yanfei
>
It's looking pretty good -- a couple minor points/questions:
(1) in display_memory(), why re-initialize the error_handle each
time through the loop, instead of doing it just once?
(2) in display_memory(), shouldn't the "lost" variable be reset
to 0 after a line of output is printed?
Hello Zhang,
Never mind (2) -- my misunderstanding, it still needs to be reflected
in the cumulative total.
That being said:
(1) I'll just move the error_handle initialization up above the loop
(2) To avoid confusion with "-c", I think I'll change the option
letter to "-x" (for context") and rewrite the help description
slightly.
Other than that, consider it queued for crash-6.0.4.
Thanks,
Dave