[Crash-utility] Re: [PATCH v4 13/16] set_context(): check if context is already current

On Fri, May 31, 2024 at 5:38 PM <devel-request(a)lists.crash-utility.osci.io&gt; wrote: > > Date: Fri, 31 May 2024 17:19:36 +0800 > From: Tao Liu <ltao(a)redhat.com&gt; > Subject: [Crash-utility] [PATCH v4 13/16] set_context(): check if > context is already current > To: devel(a)lists.crash-utility.osci.io > Cc: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt;, Mahesh J > Salgaonkar <mahesh(a)linux.ibm.com&gt;, "Naveen N . Rao" > <naveen.n.rao(a)linux.vnet.ibm.com&gt;, Lianbo Jiang <lijiang(a)redhat.com&gt; > Message-ID: <20240531091939.97828-14-ltao(a)redhat.com&gt; > Content-Type: text/plain; charset=UTF-8 > > From: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt; > > By doing it we avoid dropping gdb caches unnecessarily. > > Cc: Sourabh Jain <sourabhjain(a)linux.ibm.com&gt; > Cc: Hari Bathini <hbathini(a)linux.ibm.com&gt; > Cc: Mahesh J Salgaonkar <mahesh(a)linux.ibm.com&gt; > Cc: Naveen N. Rao <naveen.n.rao(a)linux.vnet.ibm.com&gt; > Cc: Lianbo Jiang <lijiang(a)redhat.com&gt; > Cc: HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com&gt; > Cc: Tao Liu <ltao(a)redhat.com&gt; > Cc: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt; > Signed-off-by: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt; > --- > task.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/task.c b/task.c > index 8c00837..3814f6d 100644 > --- a/task.c > +++ b/task.c > @@ -5287,6 +5287,9 @@ set_context(ulong task, ulong pid, uint update_gdb_thread) > struct task_context *tc; > int found; > > + if (CURRENT_CONTEXT() && CURRENT_TASK() == task) > + return TRUE; > + Seems it makes sense. I would suggest also adding the pid checking as below: + if (CURRENT_CONTEXT() && (CURRENT_TASK() == task || CURRENT_PID() == pid)) + return TRUE; + What do you think?

Thanks Lianbo > tc = FIRST_CONTEXT(); > > for (i = 0, found = FALSE; i < RUNNING_TASKS(); i++, tc++) { > -- > 2.40.1