Re: [Crash-utility] [PATCH v2] Add ending identifier for union when parsing task structure

On 2022/08/31 17:59, lijiang wrote: >>> diff --git a/task.c b/task.c >>> index 071c787..db2abc8 100644 >>> --- a/task.c >>> +++ b/task.c >>> @@ -3436,7 +3436,8 @@ parse_task_thread(int argcnt, char *arglist[], >> struct task_context *tc) { >>> while (fgets(buf, BUFSIZE, pc->tmpfile)) { >>> if (STREQ(buf, " {\n")) >>> randomized = TRUE; >>> - else if (randomized && STREQ(buf, " }, \n")) >>> + else if (randomized && >>> + (STREQ(buf, " }, \n") || STREQ(buf, " },\n"))) >> > > This change looks good, and the test is ok. So for the v2: Ack. Applied, I've changed the commit title a little. https://github.com/crash-utility/crash/commit/9cbfea67eb4f094d47cd841b73d...

Thanks, Kazu