Re: [Crash-utility] [PATCH] add arm support for libgcore
----- Original Message -----
Hello Lei,
Thanks for making patch. I'll check your patch this week, but I have
two things to ask you.
1. I don't know arm architecture at all and I don't have arm
machine. What I can do is only testing common part and regression test
on x86 architecture. Please maintain arm part yourself.
2. Could you tell me specific kernel versions you have tested this
patch in? I myself have yet to do this, but now I think it necessary
to make such a list. I imagine just like makedumpfile's SUPPORTED
KERNELS described in its README. I'll put them in gcore's README and
then ask Dave to add them into description in distribution page.
Hello Daisuke,
Please also note that I have changed the downloadable file on the
crash extension modules web page to crash-gcore-command-1.0.tar.gz
from the older gcore.tar.bz2. Keeping a versioned package will
make our maintenance chores a bit easier.
Also, when the package is compiled from within an rpmbuild framework
using $(RPM_OPT_FLAGS), the gcore_get_regs_from_bt_output() function
generates a compiler warning. I've attached a patch for that.
Thanks,
Dave
HATAYAMA, Daisuke
From: Lei Wen <adrian.wenl(a)gmail.com>
Subject: [Crash-utility] [PATCH] add arm support for libgcore
Date: Mon, 13 Feb 2012 09:32:34 +0800
> Hi,
>
> Current the crash utility has the support for extracting core dump
> image from original kdump file:
> http://people.redhat.com/anderson/extensions/gcore_help_gcore.html
>
> But it only supports x86 and x86_64 now.
> I add one supporting patch to port it to ARM and another fix a minor
> bug in original implementation.
>
> Best regards,
> Lei
Attachments:
- use_RPM_OPT_FLAGS.patch (text/x-patch — 2.3 KB)