Re: [Crash-utility] patch to add vmss memory regions support

----- Original Message ----- OK thanks, but now can you re-work the patch so that crash builds cleanly with "make warn"? Here on an x86_64 with gcc-4.7.2: $ make warn TARGET: X86_64 CRASH: 7.1.1rc12 GDB: 7.6 cc -c -g -DX86_64 -DLZO -DSNAPPY -DGDB_7_6 build_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DX86_64 -DLZO -DSNAPPY -DGDB_7_6 vmware_vmss.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security vmware_vmss.c: In function ‘vmware_vmss_init’: vmware_vmss.c:218:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmware_vmss.c:222:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmware_vmss.c:225:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmware_vmss.c:228:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmware_vmss.c:231:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] ... And then for a quick sanity check, I noted that the patch won't even compile at all on an ARM64 machine: $ make warn TARGET: ARM64 CRASH: 7.1.0 GDB: 7.6 cc -c -g -DARM64 -DGDB_7_6 build_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DARM64 -DGDB_7_6 netdump.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security cc -c -g -DARM64 -DGDB_7_6 vmware_vmss.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security vmware_vmss.c: In function ‘vmware_vmss_init’: vmware_vmss.c:218:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmss.regionscount = *(uint32_t*)val; ^ vmware_vmss.c:222:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmss.regions[idx[0]].startpagenum = *(uint32_t*)val; ^ vmware_vmss.c:225:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmss.regions[idx[0]].startppn = *(uint32_t*)val; ^ vmware_vmss.c:228:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmss.regions[idx[0]].size = *(uint32_t*)val; ^ vmware_vmss.c:231:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] vmss.alignmask = *(uint32_t*)val; ^ vmware_vmss.c: In function ‘vmware_vmss_page_size’: vmware_vmss.c:277:9: error: ‘PAGE_SIZE’ undeclared (first use in this function) return PAGE_SIZE; ^ vmware_vmss.c:277:9: note: each undeclared identifier is reported only once for each function it appears in vmware_vmss.c: In function ‘read_vmware_vmss’: vmware_vmss.c:287:37: error: ‘PAGE_SHIFT’ undeclared (first use in this function) uint32_t ppn = (uint32_t) (pos >> PAGE_SHIFT); ^ vmware_vmss.c: In function ‘vmware_vmss_page_size’: vmware_vmss.c:278:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ make[4]: *** [vmware_vmss.o] Error 1 make[3]: *** [gdb] Error 2 make[2]: *** [rebuild] Error 2 make[1]: *** [gdb_merge] Error 2 make: *** [warn] Error 2 $ And that's because PAGE_SIZE is only #define'd in defs.h for x86_64, and and PAGE_SHIFT is only #define'd in defs.h for x86_64 and ppc32. There are machdep->pagesize and machdep->pageshift that get assigned for each architecture. So you could use machdep->pageshift in your patch to read_vmware_vmss(). But then there's this: uint vmware_vmss_page_size(void) { - return 4096; + return PAGE_SIZE; } which is pretty much the wrong way to do it both before and after. I'm not sure how you want to handle it. Dave