Re: [Crash-utility] [PATCH v3] add option -s and -S for subcommand irq
----- Original Message -----
Hi,
I can confirm that hooking in generic_show_interrupts() and
generic_get_irq_affinity() results in meaningful output for ARM as
well, using PATCH v3.
OK good, I'll add that. I'll change the machine_type() iteration into
"if (machdep->show_interrupts)" and "if
(machdep->get_irq_affinity)"
before it gets out of hand...
I've got another suggestion however. How about mimicking the kernel
code a little closer?
fs/proc/interrupts.c
will keep going for one more iteration, i.e. while <=nr_irqs and
kernel/irq/proc.c:show_interrupts()
will call arch_show_interrupts() when called with ==nr_irqs.
In Crash we could do this in cmd_irq
for (i = 0; i <= nr_irqs; i++)
machdep->show_interrupts(i, cpus);
and this at the start of generic_show_interrupts():
if (irq >= machdep->nr_irqs) {
return;
}
making it possible to have machdep->show_interrupts point to a wrapper
function like:
static void arm_show_interrupts(int irq, ulong *cpus)
{
if (irq == machdep->nr_irqs) {
// Show FIQ
// Show IPI
}
else {
generic_show_interrupts(irq, cpus);
}
}
Just an idea.
Regards,
Per
How about we get this patch into place first, and then you can
post a patch after crash-6.0.3 is released.
Thanks,
Dave