[Crash-utility] Re: [PATCH v2] Fix 'rd' command for zram data display in Linux 6.2+
On 2023/11/20 17:43, lijiang wrote:
> Lianbo, zram related offsets have some typos, irregular names and
lack
> of "help -o" output. I made the patch 2/2 in this opportunity, could
> you review this too?
>
>
Sorry for the late response, Kazu and Chengen.
These two patches in attachment are fine to me, only two comments:
For patch [1], it has two related kernel commits, another one
is: 84b33bf78889 ("zram: introduce recompress sysfs knob")
Thanks for the info, I'll add this.
For patch[2], I saw the crash extensions include the defs.h, could
you
please check if the relevant variables are referenced directly in the crash
extensions? If no, it does not break compatibility.
As far as I've looked for, no extension module uses them. Even if any,
the patch does not change the offset of the existing members, so it will
not break extension modules previously compiled with old definitions.
Thanks,
Kazu
Otherwise, for the patch[1] and [2]: Ack.
Thanks.
Lianbo