[Crash-utility] Re: [PATCH] vmcoreinfo: read vmcoreinfo using 'vmcoreinfo_data' when unavailable in elf note

Ping. Any comments on this ?

Thanks, - Aditya G On 18/06/25 11:02, Aditya Gupta wrote: > Few vmcores don't have vmcoreinfo elf note, such as those created using > virsh-dump. > > On architectures such as PowerPC64, vmcoreinfo is mandatory to fetch the > first_vmalloc_address, for vmcores of upstream linux, since crash-utility commit: > > commit 5b24e363a898 ("get vmalloc start address from vmcoreinfo") > > Try reading from the 'vmcoreinfo_data' symbol instead, if the vmcoreinfo > crash tries to read in case of diskdump/netdump is empty/missing. > > The approach to read 'vmcoreinfo_data' was used for a live kernel, which can be > reused in the case of missing vmcoreinfo note also, as the > 'vmcoreinfo_data' symbol is available with vmcore too > > Note though, till GDB interface is not initialised, reading from > vmcoreinfo_data symbol is not done, so behaviour is same as previously > with no vmcoreinfo (only till GDB interface is not initialised) > > Hence rename 'vmcoreinfo_read_string' in kernel.c to > 'vmcoreinfo_read_from_memory', and use it in netdump.c and diskdump.c > too. > > Reported-by: Anushree Mathur <anushree.mathur(a)linux.ibm.com&gt; > Reported-by: Kowshik Jois <kowsjois(a)linux.ibm.com&gt; > Tested-by: Anushree Mathur <anushree.mathur(a)linux.ibm.com&gt; > Tested-by: Kowshik Jois <kowsjois(a)linux.ibm.com&gt; > Signed-off-by: Aditya Gupta <adityag(a)linux.ibm.com&gt; > ...