Re: [Crash-utility] [PATCH] fix loop index

Hi. In x86_xen_kdump_p2m_create(), same valuable(i) is used as for-loop index, where one for-loop is inside the another for-loop. As a result, if debug level is equal to or larger than 7, outer for-loop is repeated only once. This patch fixes this bug. Thanks. Daisuke Nishimura.

------------------------------------------------------------------------ diff -uprN crash-4.0-4.6.org/x86.c crash-4.0-4.6/x86.c --- crash-4.0-4.6.org/x86.c 2007-08-28 00:51:11.000000000 +0900 +++ crash-4.0-4.6/x86.c 2007-09-06 10:13:37.000000000 +0900 @@ -4141,9 +4141,9 @@ x86_xen_kdump_p2m_create(struct xen_kdum if (CRASHDEBUG(7)) { up = (ulong *)xkd->page; - for (i = 0; i < 256; i++) { + for (j = 0; j < 256; j++) { fprintf(fp, "%08lx: %08lx %08lx %08lx %08lx\n", - (ulong)((i * 4) * sizeof(ulong)), + (ulong)((j * 4) * sizeof(ulong)), *up, *(up+1), *(up+2), *(up+3)); up += 4; } ------------------------------------------------------------------------ -- Crash-utility mailing list Crash-utility(a)redhat.com https://www.redhat.com/mailman/listinfo/crash-utility