On Thu, May 7, 2020 at 8:34 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com> wrote:
> > Dave,
> >
> > > Initially Kazuhito will primarily be handling upstream github duties,
> > > while Lianbo and Bhupesh will be handling Fedora, CentOS stream, and
> > > RHEL maintenance. All three will be involved in the acceptance of
> > > patches posted on this mailing list. Please welcome them in their
> > > new roles; I am confident they will do a terrific job.
> >
> > Maybe, is it better to send patch set via github as PR from now on? I'm now
writing
> > zram patch set for x86-64 support.
>
> Hi Daisuke,
>
> Good question -- and one that I shall defer the answer to the new maintainers.
>
> Personally, I never accepted git pull requests because I always felt that
> it was more valuable to expose proposed patches to the larger audience
> that make up this mailing list. So when PRs came in, I coerced the
> submitter to use the list.
I'm thinking that we continue this way as-is and I'd like to do so
because of the same reason Dave says.
Crash's watchers [1] receives Issues/PR emails, but there are 55 people
now (although the number would increase if we use GitHub mainly),
while the crash-utility mailing list has several hundreds members.
(And I personally think that it's easier to discuss things via email,
which I'm used to.)
If it's hard for us to continue the way or using GitHub looks much more
efficient in the future, then we can shift it to a GitHub way.
[1]
https://github.com/crash-utility/crash/watchers
Thanks a lot Dave for introducing us to the rest of the crash-utility
users and thanks for all your work in maintaining and managing the
crash-utility. It's pretty useful tool to have and its nice to see its
user-base increasing so rapidly.
I agree with Kazu here, handling patches (for features/bug-fixes) via
crash-utility mailing list offer couple of advantages:
- It's easier for me to review patches and discuss patches via email.
Since I review a variety of other kernel/user-space package related
patches, I would prefer handling crash-utility patches in the same
way.
- Its easier to maintain patch history and ACK process via an email -
there are already some automated tools available for them.
Also, like Kazu said, this is just a start - if we see issues, we can
always jump back to the github way (pull request/bug-repots) in the
future.
Regards,
Bhupesh