Re: [Crash-utility] [PATCH] ppc64: fix crash load failure

>> I checked the crash code. For the s390x, it doesn't invoke the >> map_cpus_to_prstatus{_kdump_cmprs}(), so this patch should not affect > the >> s390x arch. > > My thought is that the original commit db8c030857b4 should have added > the initialization of SIZE(note_buf) in task_init(), because there might > be some architectures that do not initialize it and it's better to > initialize it when it's used, e.g. like this: > > --- a/task.c > +++ b/task.c > @@ -675,6 +675,8 @@ task_init(void) > tt->this_task = pid_to_task(active_pid); > } > else { > + if (INVALID_SIZE(note_buf)) > + STRUCT_SIZE_INIT(note_buf, "note_buf_t"); > if (KDUMP_DUMPFILE()) > map_cpus_to_prstatus(); > else if (ELF_NOTES_VALID() && DISKDUMP_DUMPFILE()) > > Ok, fine to me. But, generally it should be good to be initialized in the machdep_init() because the note_buf is strongly related to the crash_notes, and the crash_notes contains machine specific information such as cpu registers at the time of crash.