New subject: minor bug in get_text_init_space

Wednesday, 29 September 2010

----- "Per Fransson" <perr.fransson.ml(a)gmail.com&gt; wrote:

...
 Hi,

 I believe the ARM support introduced a minor issue in the function
 get_text_init_space(). As it stands, the error "cannot determine text
 init space" can only occur when machine_type("ARM") is true. Here a
 suggested fix.

 Regards,
 Per 
Definitely a bug -- thanks for catching that.  

I remember looking at that ARM-support patch submission and thinking
that for maintainability/sanity purposes it should probably just be
separated out entirely for ARM.

Thanks again,
  Dave

...

 --- a/symbols.c
 +++ b/symbols.c
 @@ -491,9 +491,9 @@ get_text_init_space(void)

         if (((section = get_kernel_section(".text.init")) == NULL) &&
             ((section = get_kernel_section(".init.text")) == NULL) &&
 -           (machine_type("ARM") && (section =
get_kernel_section(".init")) == NULL)) {
 -               error(WARNING, "cannot determine text init space\n");
 -               return;
 +           !(machine_type("ARM") && (section =
get_kernel_section(".init")) != NULL)) {
 +           error(WARNING, "cannot determine text init space\n");
 +           return;
         }

         kt->stext_init = (ulong)bfd_get_section_vma(st->bfd, section);

 --
 Crash-utility mailing list
 Crash-utility(a)redhat.com
 https://www.redhat.com/mailman/listinfo/crash-utility 

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Re: [Crash-utility] minor bug in get_text_init_space