>>>> The problem happens only with module symbols, not with kallsyms. >>>> >>>> crash> sym -M >>>> c008000007810000 MODULE START: crc32c_vpmsum >>>> c008000007810000 (^R) __crc32c_vpmsum >>>> c008000007810670 (^B) crc32c_vpmsum_cra_init >>>> c008000007810690 (^B) crc32c_vpmsum_setkey >>> >>> Hi Ravi, >>> >>> I have never seen this before,

>>> but nonetheless, it does seem that Steve's >>> patch >>> to the trace.c module is the better course of action. Does it work OK for >>> you?

----- Original Message ----- > > On 3/19/19 6:48 PM, Dave Anderson wrote: > >>>>> The problem happens only with module symbols, not with kallsyms. > >>>>> > >>>>> crash> sym -M > >>>>> c008000007810000 MODULE START: crc32c_vpmsum > >>>>> c008000007810000 (^R) __crc32c_vpmsum > >>>>> c008000007810670 (^B) crc32c_vpmsum_cra_init > >>>>> c008000007810690 (^B) crc32c_vpmsum_setkey > >>>> > >>>> Hi Ravi, > >>>> > >>>> I have never seen this before, > > Simply do: > > # crash vmcore vmlinux > crash> sym -M > c008000007810000 MODULE START: crc32c_vpmsum > c008000007810000 (^R) __crc32c_vpmsum > c008000007810670 (^B) crc32c_vpmsum_cra_init > > But cmd_mod() seems to be doing right thing: > > crash> mod -s crc32c_vpmsum > crash> sym -M > c008000007810000 MODULE START: crc32c_vpmsum > c008000007810000 (T) __crc32c_vpmsum > c008000007810670 (t) crc32c_vpmsum_cra_init Yeah, although I don't have crc32c_vpmsum module installed on my RHEL7 host system, I don't see it with any other modules. I'll provision a 5.0.0-based system and see if it happens there.

> > >>>> but nonetheless, it does seem that Steve's patch > >>>> to the trace.c module is the better course of action. Does it work OK > >>>> for you? > > Yes Steve's patch fixes trace segfault for me. Ok good, thanks. I've cc'd this to the maintainer -- Xu, can you please review the patchset? Thanks, Dave

On Wed, 20 Mar 2019 10:25:44 -0400 (EDT) Dave Anderson <anderson(a)redhat.com&gt; wrote: > > >>>> but nonetheless, it does seem that Steve's patch > > >>>> to the trace.c module is the better course of action. Does it work > > >>>> OK > > >>>> for you? > > > > Yes Steve's patch fixes trace segfault for me. > > Ok good, thanks. > > I've cc'd this to the maintainer -- Xu, can you please review the patchset? BTW, I tried to subscribe to the crash-utility discussion list, with no response. I'd like to take a more active role in helping to maintain the trace.so extension as I'm the one that will be breaking it in the future ;-) Also, I now have a team working on trace-cmd and the trace.dat file will be getting more features that crash may want to take advantage of. -- Steve