Thank you for the great work, Tao.
On Thu, Feb 20, 2025 at 11:26 AM lijiang <lijiang(a)redhat.com> wrote:
 On Thu, Feb 6, 2025 at 3:05 PM
<devel-request(a)lists.crash-utility.osci.io>
 wrote:
> Date: Thu,  6 Feb 2025 20:04:11 +1300
> From: Tao Liu <ltao(a)redhat.com>
> Subject: [Crash-utility] [PATCH v2 0/3] Update to gdb-16.2
> To: devel(a)lists.crash-utility.osci.io
> Cc: Tao Liu <ltao(a)redhat.com>
> Message-ID: <20250206070418.1038668-1-ltao(a)redhat.com>
> Content-Type: text/plain; charset="US-ASCII"; x-default=true
>
> v2 -> v1: Splite the "Fix several build failures" patchset, which is
>           already merged btw, from gdb v16.2 upgrading.
>
 Thank you for the update, Tao.
 I will have a look next week.
 
For the patch [ v2 1/3], let's leave it for the time being, hope the
LoongArch people can help to fix it ASAP.
For the patch [v2 2/3] and [v2 3/3], the code looks good to me, but I have
regenerated the patches and improved them:
https://github.com/crash-utility/crash/commit/dfb2bb55e530db076e41cb0e41a...
Thanks
Lianbo
 Thanks
 Lianbo
>
> Tao Liu (3):
>   LoongArch64: Revert all previous LoongArch64 related commits
>   Revert: Fix C99 compatibility issues in embedded copy of GDB
>   Update to gdb-16.2
>
>  Makefile            |    10 +-
>  README              |     6 +-
>  configure.c         |    64 +-
>  crash.8             |     2 +-
>  crash_target.c      |     6 +-
>  defs.h              |   174 +-
>  diskdump.c          |    24 +-
>  gdb-10.2.patch      | 16323 ------------------------------------------
>  gdb-16.2.patch      |  2254 ++++++
>  gdb_interface.c     |    14 +-
>  help.c              |    15 +-
>  kernel.c            |     6 +-
>  lkcd_vmdump_v1.h    |     2 +-
>  lkcd_vmdump_v2_v3.h |     5 +-
>  loongarch64.c       |  1368 ----
>  main.c              |     3 +-
>  netdump.c           |    27 +-
>  ramdump.c           |     2 -
>  symbols.c           |    37 +-
>  19 files changed, 2322 insertions(+), 18020 deletions(-)
>  delete mode 100644 gdb-10.2.patch
>  create mode 100644 gdb-16.2.patch
>  delete mode 100644 loongarch64.c
>
> --
> 2.47.0
>