-----Original Message----- From: crash-utility-bounces(a)redhat.com [mailto:crash-utility- bounces(a)redhat.com] On Behalf Of Dave Anderson Sent: Tuesday, October 14, 2014 9:35 PM To: Discussion list for crash utility usage, maintenance and development Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.3.0-rc is released Hello Daisuke, Thanks for the update -- I will post my results later. However, I note that you did not make the small ARM64 update that I emailed to you last week: This should be changed: #ifdef ARM64 #define ELF_EXEC_PAGESIZE 4096 to: #ifdef ARM64 #define ELF_EXEC_PAGESIZE PAGESIZE() Please make that change. Thanks, Dave ----- Original Message ----- > This is the release of crash gcore command, version 1.3.0-rc. > > The version 1.3.0 is going to newly add ARM64 support, and the purpose > of this rc version release is for verification by other architecture > maintainers. Please give me a verfication result as a reply to this > mail. > > The remaining changes are all bugfixes. > > ChangeLog: > > - Add ARM64 support. In addition to native ARM64 build, like crash > utility, we can build x86_64 executable of crash gcore command for > ARM64 crash dump by make target=ARM64, just like crash utility. > (anderson(a)redhat.com) > > - Fix a bug that registers in NT_PRSTATUS note information is > broken. This had been since v1.2.2 when O(1) note informaiton > collection was added. Without this fix, we can never get reliable > register values for failure analysis. > (weishu(a)marvell.com) > > - Fix a bug that NT_386_IOPERM note information is not collected. So > far, ioperm_get() had always returned 1. As a result, NT_386_IOPERM > note information had never been not included in a generated core > file even if it is available for a given task on a given crash > dump. > (d.hatayama(a)jp.fujitsu.com) > > - Add new member offset initialization for struct > nsproxy::pid_ns_for_children. In upstream, the following patch > renamed struct nsproxy::pid_ns into struct > nsproxy::pid_ns_for_children. > > $ git log -1 c2b1df2e > commit c2b1df2eb42978073ec27c99cc199d20ae48b849 > Author: Andy Lutomirski <luto(a)amacapital.net&gt; > Date: Thu Aug 22 11:39:16 2013 -0700 > > Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children > > nsproxy.pid_ns is *not* the task's pid namespace. The name > should clarify > that. > > This makes it more obvious that setns on a pid namespace is weird - - > it won't change the pid namespace shown in procfs. > > Signed-off-by: Andy Lutomirski <luto(a)amacapital.net&gt; > Reviewed-by: "Eric W. Biederman" <ebiederm(a)xmission.com&gt; > Signed-off-by: David S. Miller <davem(a)davemloft.net&gt; > > Without this fix, gcore exited abnormally at its initialization > part and so core file is never generated. > (d.hatayama(a)jp.fujitsu.com) > > - Fix a bug that a wrong way of checking return value of > fopen(). fopen() returns NULL in case of error, but gcore had seen > it as returning a minus integer. As a result, gcore continues > execution after the check even in case of error and then exits > abnormally at the first call of fwrite() with the broken file > pointer gcore failed to open. > > From users' viewpoint, we face this bug when trying to overwrite an > existing corefile with more priviledged permission and resulting in > EPERM failure. > > (d.hatayama(a)jp.fujitsu.com) > > MD5 CheckSum: > > $ md5sum ./crash-gcore-command-1.3.0-rc.tar.gz > 0b841985c084e790966800edfd1b5d43 > ./crash-gcore-command-1.3.0-rc.tar.gz > > -- > Thanks. > HATAYAMA, Daisuke > > -- > Crash-utility mailing list > Crash-utility(a)redhat.com > https://www.redhat.com/mailman/listinfo/crash-utility -- Crash-utility mailing list Crash-utility(a)redhat.com https://www.redhat.com/mailman/listinfo/crash-utility

-----Original Message----- From: HATAYAMA, Daisuke [mailto:d.hatayama@jp.fujitsu.com] Sent: Wednesday, October 15, 2014 5:24 PM To: Wei Shu Cc: Discussion list for crash utility usage, maintenance and development Subject: Re: [Crash-utility] crash gcore command, version 1.3.0-rc is released Hi Wei, (2014/10/15 11:51), Wei Shu wrote: > Hi Daisuke, > > how about the ARM64 compat mode support? I have sent out the patch before, thanks > I cannot find your patch. In July? Could you point it? -- Thanks. HATAYAMA, Daisuke

Hi Daisuke, attatched

Hello Daisuke, Thanks for the update -- I will post my results later. However, I note that you did not make the small ARM64 update that I emailed to you last week: This should be changed: #ifdef ARM64 #define ELF_EXEC_PAGESIZE 4096 to: #ifdef ARM64 #define ELF_EXEC_PAGESIZE PAGESIZE() Please make that change.

----- Original Message ----- > > > (2014/10/14 22:34), Dave Anderson wrote: > > > > Hello Daisuke, > > > > Thanks for the update -- I will post my results later. > > > > However, I note that you did not make the small ARM64 update > > that I emailed to you last week: > > > > This should be changed: > > > > #ifdef ARM64 > > #define ELF_EXEC_PAGESIZE 4096 > > > > to: > > > > #ifdef ARM64 > > #define ELF_EXEC_PAGESIZE PAGESIZE() > > > > Please make that change. > > > > I'll merge this in the next rc release. OK good -- thanks. I have successfully tested this version (with the fix above) on ARM64 kernels configured with 4K and 64K pages, and also when the gcore module is built and run on an x86_64 host with an ARM64 target.

Another question: another engineer here at Red Hat has recently created a crash-gcore-command patch that implements support for PPC64, both big-endian and little-endian. May we post that patch for inclusion in version 1.3.0?

----- Original Message ----- > From: Dave Anderson <anderson(a)redhat.com&gt; > Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version > 1.3.0-rc > is released > Date: Wed, 15 Oct 2014 15:11:44 -0400 > > > > > > > ----- Original Message ----- > >> > >> > >> (2014/10/14 22:34), Dave Anderson wrote: > >> > > >> > Hello Daisuke, > >> > > >> > Thanks for the update -- I will post my results later. > >> > > >> > However, I note that you did not make the small ARM64 update > >> > that I emailed to you last week: > >> > > >> > This should be changed: > >> > > >> > #ifdef ARM64 > >> > #define ELF_EXEC_PAGESIZE 4096 > >> > > >> > to: > >> > > >> > #ifdef ARM64 > >> > #define ELF_EXEC_PAGESIZE PAGESIZE() > >> > > >> > Please make that change. > >> > > >> > >> I'll merge this in the next rc release. > > > > OK good -- thanks. > > > > I have successfully tested this version (with the fix above) on ARM64 > > kernels configured with 4K and 64K pages, and also when the gcore module > > is built and run on an x86_64 host with an ARM64 target. > > > > Thanks. > > > Another question: another engineer here at Red Hat has recently > > created a crash-gcore-command patch that implements support for PPC64, > > both big-endian and little-endian. May we post that patch for inclusion > > in version 1.3.0? > > > > Sure. It's no problem to merge PPC64 patche. Please post it. > > However, as you've understood, I have no PPC64 system. I cannot test > PPC64 arch at all. > > Also, who will maintain the PPC64 code? The engineer? or you'll do it > in addition to ARM64? Correct, support for both architectures will come from here (Red Hat) since they eventually will be RHEL packages. IBM would also be interested in the PPC64 flavors. Thanks, Dave

于 2014/10/16 3:11, Dave Anderson 写道: > > > ----- Original Message ----- >> >> >> (2014/10/14 22:34), Dave Anderson wrote: >>> >>> Hello Daisuke, >>> >>> Thanks for the update -- I will post my results later. >>> >>> However, I note that you did not make the small ARM64 update >>> that I emailed to you last week: >>> >>> This should be changed: >>> >>> #ifdef ARM64 >>> #define ELF_EXEC_PAGESIZE 4096 >>> >>> to: >>> >>> #ifdef ARM64 >>> #define ELF_EXEC_PAGESIZE PAGESIZE() >>> >>> Please make that change. >>> >> >> I'll merge this in the next rc release. > > OK good -- thanks. > > I have successfully tested this version (with the fix above) on ARM64 > kernels configured with 4K and 64K pages, and also when the gcore module > is built and run on an x86_64 host with an ARM64 target. > > Another question: another engineer here at Red Hat has recently > created a crash-gcore-command patch that implements support for PPC64, > both big-endian and little-endian. May we post that patch for inclusion > in version 1.3.0? > Where can i find the patch?