9:04 a.m.
Since linux-next commit fe1e19081321 ("mm: Split slab into its own type"),
the struct slab is used for both SLAB and SLUB. Therefore, don't depend
on the non-presence of the struct slab to decide whether SLAB implementation
should be chosen and use the member variable "cpu_slab" of the struct
kmem_cache instead, it should be present only in SLUB.
Signed-off-by: Alexander Egorenkov <egorenar(a)linux.ibm.com>
---
memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/memory.c b/memory.c
index 86c02c132890..5af45fd7d834 100644
--- a/memory.c
+++ b/memory.c
@@ -576,7 +576,8 @@ vm_init(void)
STRUCT_SIZE_INIT(cpucache_s, "cpucache_s");
} else if (!VALID_STRUCT(kmem_slab_s) &&
- !VALID_STRUCT(slab_s) &&
+ !VALID_STRUCT(slab_s) &&
+ !MEMBER_EXISTS("kmem_cache", "cpu_slab") &&
(VALID_STRUCT(slab) || (vt->flags & SLAB_OVERLOAD_PAGE))) {
vt->flags |= PERCPU_KMALLOC_V2;
--
2.31.1
11:42 p.m.
New subject: [PATCH 1/1] memory: Handle struct slab changes in linux-next
Hi Alex,
-----Original Message-----
Since linux-next commit fe1e19081321 ("mm: Split slab into its
own type"),
the struct slab is used for both SLAB and SLUB. Therefore, don't depend
on the non-presence of the struct slab to decide whether SLAB implementation
should be chosen and use the member variable "cpu_slab" of the struct
kmem_cache instead, it should be present only in SLUB.
Signed-off-by: Alexander Egorenkov <egorenar(a)linux.ibm.com>
Thanks for the early fix as always. It looks good to me.
We'd like to add the error message to the commit log:
---
Without the patch, crash fails to start with the error message:
crash: invalid structure member offset: kmem_cache_s_num
FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init()
---
Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
btw, kmem -s does not work well with the current linux-next.
I've not looked into it yet, any patches would be helpful.
Thanks,
Kazu
---
memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/memory.c b/memory.c
index 86c02c132890..5af45fd7d834 100644
--- a/memory.c
+++ b/memory.c
@@ -576,7 +576,8 @@ vm_init(void)
STRUCT_SIZE_INIT(cpucache_s, "cpucache_s");
} else if (!VALID_STRUCT(kmem_slab_s) &&
- !VALID_STRUCT(slab_s) &&
+ !VALID_STRUCT(slab_s) &&
+ !MEMBER_EXISTS("kmem_cache", "cpu_slab") &&
(VALID_STRUCT(slab) || (vt->flags & SLAB_OVERLOAD_PAGE))) {
vt->flags |= PERCPU_KMALLOC_V2;
--
2.31.1
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://listman.redhat.com/mailman/listinfo/crash-utility
5:51 a.m.
Hi Kazu,
HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com> writes:
Hi Alex,
-----Original Message-----
> Since linux-next commit fe1e19081321 ("mm: Split slab into its own type"),
> the struct slab is used for both SLAB and SLUB. Therefore, don't depend
> on the non-presence of the struct slab to decide whether SLAB implementation
> should be chosen and use the member variable "cpu_slab" of the struct
> kmem_cache instead, it should be present only in SLUB.
>
> Signed-off-by: Alexander Egorenkov <egorenar(a)linux.ibm.com>
Thanks for the early fix as always. It looks good to me.
We'd like to add the error message to the commit log:
---
Without the patch, crash fails to start with the error message:
crash: invalid structure member offset: kmem_cache_s_num
FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init()
---
Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
Thanks! Looks good.
btw, kmem -s does not work well with the current linux-next.
I've not looked into it yet, any patches would be helpful.
Thanks for the hint, i'll look into it when i have time, was not aware
of it.
Regards
Alex
6:23 p.m.
-----Original Message-----
Hi Kazu,
HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com> writes:
> Hi Alex,
>
> -----Original Message-----
>> Since linux-next commit fe1e19081321 ("mm: Split slab into its own
type"),
now I can see the commit in upstream with another commit id.
Thanks for the reminder, Alex. :)
Lianbo, please modify the subject and message like this when merging
after your review:
---
Subject: memory: Handle struct slab changes on Linux 5.17-rc1 and later
Since kernel commit d122019bf061 ("mm: Split slab into its own type"),
...
Without the patch, crash fails to start with the error message:
crash: invalid structure member offset: kmem_cache_s_num
FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init()
---
Thanks,
Kazu
>> the struct slab is used for both SLAB and SLUB. Therefore,
don't depend
>> on the non-presence of the struct slab to decide whether SLAB implementation
>> should be chosen and use the member variable "cpu_slab" of the struct
>> kmem_cache instead, it should be present only in SLUB.
>>
>> Signed-off-by: Alexander Egorenkov <egorenar(a)linux.ibm.com>
>
> Thanks for the early fix as always. It looks good to me.
> We'd like to add the error message to the commit log:
> ---
> Without the patch, crash fails to start with the error message:
>
> crash: invalid structure member offset: kmem_cache_s_num
> FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init()
> ---
>
> Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
>
Thanks! Looks good.
> btw, kmem -s does not work well with the current linux-next.
> I've not looked into it yet, any patches would be helpful.
>
Thanks for the hint, i'll look into it when i have time, was not aware
of it.
Regards
Alex
8:32 p.m.
On Wed, Jan 12, 2022 at 8:23 AM HAGIO KAZUHITO(萩尾 一仁)
<k-hagio-ab(a)nec.com> wrote:
-----Original Message-----
> Hi Kazu,
>
>
> HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com> writes:
>
> > Hi Alex,
> >
> > -----Original Message-----
> >> Since linux-next commit fe1e19081321 ("mm: Split slab into its own
type"),
now I can see the commit in upstream with another commit id.
Thanks for the reminder, Alex. :)
Lianbo, please modify the subject and message like this when merging
after your review:
Yesterday, I just saw this commit in the linux branch.
And the fix looks good, applied(with the patch log changes).
Thanks.
Lianbo
---
Subject: memory: Handle struct slab changes on Linux 5.17-rc1 and later
Since kernel commit d122019bf061 ("mm: Split slab into its own type"),
...
Without the patch, crash fails to start with the error message:
crash: invalid structure member offset: kmem_cache_s_num
FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init()
---
Thanks,
Kazu
> >> the struct slab is used for both SLAB and SLUB. Therefore, don't
depend
> >> on the non-presence of the struct slab to decide whether SLAB
implementation
> >> should be chosen and use the member variable "cpu_slab" of the
struct
> >> kmem_cache instead, it should be present only in SLUB.
> >>
> >> Signed-off-by: Alexander Egorenkov <egorenar(a)linux.ibm.com>
> >
> > Thanks for the early fix as always. It looks good to me.
> > We'd like to add the error message to the commit log:
> > ---
> > Without the patch, crash fails to start with the error message:
> >
> > crash: invalid structure member offset: kmem_cache_s_num
> > FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init()
> > ---
> >
> > Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
> >
>
> Thanks! Looks good.
>
>
> > btw, kmem -s does not work well with the current linux-next.
> > I've not looked into it yet, any patches would be helpful.
> >
>
> Thanks for the hint, i'll look into it when i have time, was not aware
> of it.
>
> Regards
> Alex
899
days inactive
936
days old
devel@lists.crash-utility.osci.io
4 comments
3 participants
participants (3)
-
Alexander Egorenkov -
HAGIO KAZUHITO(萩尾 一仁) -
lijiang