4:30 p.m.
Expand s390x bt output.
Add basic 'bt -e' support for s390x.
Mikhail Zaslonko (2):
s390x: Expand bt output with PSW mode and pt_regs address
s390x: Add basic 'bt -e' support for s390x
Changelog:
V2->V3:
- Fix build warnings.
s390x.c | 45 +++++++++++++++++++++++++++++++++------------
1 file changed, 33 insertions(+), 12 deletions(-)
--
2.49.0
4:30 p.m.
New subject: [PATCH v3 1/2] s390x: Expand bt output with PSW mode and pt_regs address
Print the following line for the stack frame with zero backchain
pointer prior to printing PSW and GPRS:
KERNEL-MODE INTERRUPT FRAME; pt_regs at <address>:
or
USER-MODE INTERRUPT FRAME; pt_regs at <address>:
Suggested-by: Heiko Carstens <hca(a)linux.ibm.com>
Signed-off-by: Mikhail Zaslonko <zaslonko(a)linux.ibm.com>
---
s390x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/s390x.c b/s390x.c
index 77d9082..e8c6343 100644
--- a/s390x.c
+++ b/s390x.c
@@ -1733,6 +1733,7 @@ static unsigned long show_trace(struct bt_info *bt, int cnt,
unsigned long sp,
/* Check for user PSW */
reg = readmem_ul(sp + MEMBER_OFFSET("pt_regs", "psw"));
if (reg & S390X_PSW_MASK_PSTATE) {
+ fprintf(fp, " USER-MODE INTERRUPT FRAME; pt_regs at %lx:\n", sp);
print_ptregs(bt, sp);
return sp;
}
@@ -1745,6 +1746,7 @@ static unsigned long show_trace(struct bt_info *bt, int cnt,
unsigned long sp,
/* Check for loop (kernel_thread_starter) of second zero bc */
if (low == reg || reg == 0)
return reg;
+ fprintf(fp, " KERNEL-MODE INTERRUPT FRAME; pt_regs at %lx:\n", sp);
print_ptregs(bt, sp);
low = sp;
sp = reg;
--
2.49.0
4:30 p.m.
New subject: [PATCH v3 2/2] s390x: Add basic 'bt -e' support for s390x
Add basic 'bt -e' support for s390x printing only interrupt frame and
related pt_regs, e.g:
crash> bt -e
PID: 604 TASK: 7052a00 CPU: 1 COMMAND: "systemd-journal"
USER-MODE INTERRUPT FRAME at 38000003e98
pt_regs at 38000003f38:
PSW: 0705000180000000 000003ff8db0fa36 (user space)
GPRS: 00000000002f9112 000003ff00000000 ffffffffffffffda 000002aa2b4db520
000000000000003e ffffffffffffffff 00063ea900000007 0000000000000020
0000000000000140 000002aa2b4b5290 000003ff8e2e6b40 000000000000003e
000003ff8e17bcd0 000003ff8e2af018 000003ff8e089a02 000003ffe02f98f0
Suggested-by: Heiko Carstens <hca(a)linux.ibm.com>
Signed-off-by: Mikhail Zaslonko <zaslonko(a)linux.ibm.com>
---
s390x.c | 47 +++++++++++++++++++++++++++++++++--------------
1 file changed, 33 insertions(+), 14 deletions(-)
diff --git a/s390x.c b/s390x.c
index e8c6343..7664860 100644
--- a/s390x.c
+++ b/s390x.c
@@ -1376,12 +1376,18 @@ s390x_translate_pte(ulong pte, void *physaddr, ulonglong unused)
static int
s390x_eframe_search(struct bt_info *bt)
{
- if(bt->flags & BT_EFRAME_SEARCH2)
+ ulong esp;
+
+ if (bt->flags & BT_EFRAME_SEARCH2) {
return (error(FATAL,
"Option '-E' is not implemented for this architecture\n"));
- else
- return (error(FATAL,
- "Option '-e' is not implemented for this architecture\n"));
+ } else {
+ /* For 'bt -e' print only interrupt frames and related pt_regs */
+ s390x_get_stack_frame(bt, NULL, &esp);
+ bt->stkptr = esp;
+ s390x_back_trace_cmd(bt);
+ return 0;
+ }
}
#ifdef DEPRECATED
@@ -1699,17 +1705,19 @@ static void print_ptregs(struct bt_info *bt, unsigned long sp)
static unsigned long show_trace(struct bt_info *bt, int cnt, unsigned long sp,
unsigned long low, unsigned long high)
{
- unsigned long reg;
+ unsigned long reg, iframe_addr;
unsigned long psw_addr ATTRIBUTE_UNUSED;
while (1) {
if (sp < low || sp > high - SIZE(s390_stack_frame))
return sp;
reg = readmem_ul(sp + OFFSET(s390_stack_frame_r14));
- if (!s390x_has_cpu(bt))
- print_frame(bt, cnt++, sp, reg);
- if (bt->flags & BT_FULL)
- print_frame_data(sp, high);
+ if (!(bt->flags & BT_EFRAME_SEARCH)) {
+ if (!s390x_has_cpu(bt))
+ print_frame(bt, cnt++, sp, reg);
+ if (bt->flags & BT_FULL)
+ print_frame_data(sp, high);
+ }
/* Follow the backchain. */
while (1) {
low = sp;
@@ -1722,18 +1730,25 @@ static unsigned long show_trace(struct bt_info *bt, int cnt,
unsigned long sp,
if (sp <= low || sp > high - SIZE(s390_stack_frame))
return sp;
reg = readmem_ul(sp + OFFSET(s390_stack_frame_r14));
- print_frame(bt, cnt++, sp, reg);
- if (bt->flags & BT_FULL)
- print_frame_data(sp, high);
+ if (!(bt->flags & BT_EFRAME_SEARCH)) {
+ print_frame(bt, cnt++, sp, reg);
+ if (bt->flags & BT_FULL)
+ print_frame_data(sp, high);
+ }
}
/* Zero backchain detected, check for interrupt frame. */
+ iframe_addr = sp;
sp += SIZE(s390_stack_frame);
if (sp <= low || sp > high - STRUCT_SIZE("pt_regs"))
return sp;
/* Check for user PSW */
reg = readmem_ul(sp + MEMBER_OFFSET("pt_regs", "psw"));
if (reg & S390X_PSW_MASK_PSTATE) {
- fprintf(fp, " USER-MODE INTERRUPT FRAME; pt_regs at %lx:\n", sp);
+ if (bt->flags & BT_EFRAME_SEARCH)
+ fprintf(fp, " USER-MODE INTERRUPT FRAME at %lx\n", iframe_addr);
+ else
+ fprintf(fp, " USER-MODE INTERRUPT FRAME;");
+ fprintf(fp, " pt_regs at %lx:\n", sp);
print_ptregs(bt, sp);
return sp;
}
@@ -1746,7 +1761,11 @@ static unsigned long show_trace(struct bt_info *bt, int cnt,
unsigned long sp,
/* Check for loop (kernel_thread_starter) of second zero bc */
if (low == reg || reg == 0)
return reg;
- fprintf(fp, " KERNEL-MODE INTERRUPT FRAME; pt_regs at %lx:\n", sp);
+ if (bt->flags & BT_EFRAME_SEARCH)
+ fprintf(fp, " KERNEL-MODE INTERRUPT FRAME at %lx\n", iframe_addr);
+ else
+ fprintf(fp, " KERNEL-MODE INTERRUPT FRAME;");
+ fprintf(fp, " pt_regs at %lx:\n", sp);
print_ptregs(bt, sp);
low = sp;
sp = reg;
--
2.49.0
9:54 p.m.
On Wed, Nov 12, 2025 at 6:30 AM Mikhail Zaslonko <zaslonko(a)linux.ibm.com>
wrote:
Expand s390x bt output.
Add basic 'bt -e' support for s390x.
Mikhail Zaslonko (2):
s390x: Expand bt output with PSW mode and pt_regs address
s390x: Add basic 'bt -e' support for s390x
Changelog:
V2->V3:
- Fix build warnings.
Thank you for the update, Mikhail.
For the v3: Ack
Thanks
Lianbo
s390x.c | 45 +++++++++++++++++++++++++++++++++------------
1 file changed, 33 insertions(+), 12 deletions(-)
--
2.49.0
10:13 p.m.
applied:
https://github.com/crash-utility/crash/commit/fbb2e9e2e38d58ccf3d596359b2...
On Wed, Nov 12, 2025 at 4:55 PM lijiang <lijiang(a)redhat.com> wrote:
On Wed, Nov 12, 2025 at 6:30 AM Mikhail Zaslonko <zaslonko(a)linux.ibm.com> wrote:
>
> Expand s390x bt output.
> Add basic 'bt -e' support for s390x.
>
> Mikhail Zaslonko (2):
> s390x: Expand bt output with PSW mode and pt_regs address
> s390x: Add basic 'bt -e' support for s390x
>
> Changelog:
> V2->V3:
> - Fix build warnings.
>
Thank you for the update, Mikhail.
For the v3: Ack
Thanks
Lianbo
> s390x.c | 45 +++++++++++++++++++++++++++++++++------------
> 1 file changed, 33 insertions(+), 12 deletions(-)
>
> --
> 2.49.0
>
145
days inactive
147
days old
devel@lists.crash-utility.osci.io
4 comments
3 participants
participants (3)
-
lijiang -
ltao -
Mikhail Zaslonko