Re: [Crash-utility] [PATCH] Use /usr/bin/nm -D
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
----- "Dave Anderson" <anderson(a)redhat.com> wrote:
----- "Bernhard Walle" <bwalle(a)suse.de> wrote:
> * Dave Anderson [2008-08-25 16:07]:
> >
> > I'm not sure what's worse -- not doing the translation at all
> > or showing potentially bogus entries.
>
> *arg*, yes, I didn't check for such static functions. The functions
> in
> my test were only global, so everything worked.
>
> However, I now modified the patch to check the size (with nm -S),
and
> report "unknown" in such cases. So we still have the global symbols
> right, but no "false positives".
>
> Is that okay?
Looks OK -- I'll give it run today, and if no problems arise,
I'll queue it as is.
Thanks,
Dave
Tests fine, although the "unknown+offset" output is a bit confusing:
crash> test
test: invalid structure member offset: task_struct_next_run
FILE: test.c LINE: 23 FUNCTION: test_global()
[/tmp/crash] error trace: 80fd683 => 80fd71b => 80fd5d7 => 813e6ec
813e6ec: OFFSET_verify+126
80fd5d7: test_global+51
80fd71b: unknown+145
80fd683: cmd_test+137
test: invalid structure member offset: task_struct_next_run
FILE: test.c LINE: 23 FUNCTION: test_global()
crash>
I'm thinking maybe an "(undetermined)" string would be clearer.
Dave
* Dave Anderson [2008-08-26 09:03]:
Tests fine, although the "unknown+offset" output is a bit confusing:
crash> test
test: invalid structure member offset: task_struct_next_run
FILE: test.c LINE: 23 FUNCTION: test_global()
[/tmp/crash] error trace: 80fd683 => 80fd71b => 80fd5d7 => 813e6ec
813e6ec: OFFSET_verify+126
80fd5d7: test_global+51
80fd71b: unknown+145
80fd683: cmd_test+137
test: invalid structure member offset: task_struct_next_run
FILE: test.c LINE: 23 FUNCTION: test_global()
crash>
I'm thinking maybe an "(undetermined)" string would be clearer.
Ok for me. Should I resend a patch or do you modify that on your side?
I guess you disagree with coding style anyway. ;-)
Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
----- "Bernhard Walle" <bwalle(a)suse.de> wrote:
* Dave Anderson [2008-08-26 09:03]:
>
> Tests fine, although the "unknown+offset" output is a bit
confusing:
>
> crash> test
>
> test: invalid structure member offset: task_struct_next_run
> FILE: test.c LINE: 23 FUNCTION: test_global()
>
> [/tmp/crash] error trace: 80fd683 => 80fd71b => 80fd5d7 =>
813e6ec
>
> 813e6ec: OFFSET_verify+126
> 80fd5d7: test_global+51
> 80fd71b: unknown+145
> 80fd683: cmd_test+137
>
> test: invalid structure member offset: task_struct_next_run
> FILE: test.c LINE: 23 FUNCTION: test_global()
>
> crash>
>
> I'm thinking maybe an "(undetermined)" string would be clearer.
Ok for me. Should I resend a patch or do you modify that on your
side?
I guess you disagree with coding style anyway. ;-)
Nah, it's all set -- thanks again...
Dave
5786
days inactive
5786
days old
devel@lists.crash-utility.osci.io
2 comments
2 participants
tags (0)
participants (2)
-
Bernhard Walle -
Dave Anderson