> -----Original Message----- > Since linux kernel commit bbdbc11804ff ("arm64/crash_core: Export TCR_EL1.T1SZ in > vmcoreinfo") [available in linux-next now], the name of tcr_el1_t1sz > vmcoreinfo variable has been changed to TCR_EL1_T1SZ. > > Make a similar change in crash-utility. > > Signed-off-by: Bhupesh Sharma <bhsharma(a)redhat.com&gt; Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt; Thanks for your effort at those kernel patches! Kazu > --- > arm64.c | 2 +- > netdump.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arm64.c b/arm64.c > index 653225cd8cd6..fdf77bd5e0c1 100644 > --- a/arm64.c > +++ b/arm64.c > @@ -3922,7 +3922,7 @@ arm64_calc_VA_BITS(void) > } else if (ACTIVE()) > error(FATAL, "cannot determine VA_BITS_ACTUAL: please use /proc/kcore\n"); > else { > - if ((string = pc->read_vmcoreinfo("NUMBER(tcr_el1_t1sz)"))) { > + if ((string = pc->read_vmcoreinfo("NUMBER(TCR_EL1_T1SZ)"))) { > /* See ARMv8 ARM for the description of > * TCR_EL1.T1SZ and how it can be used > * to calculate the vabits_actual > diff --git a/netdump.c b/netdump.c > index 406416af36bf..0054d6ab35b4 100644 > --- a/netdump.c > +++ b/netdump.c > @@ -1887,7 +1887,7 @@ vmcoreinfo_read_string(const char *key) > sprintf(value, "%ld", nd->arch_data2 & 0xffffffff); > return value; > } > - if (STREQ(key, "NUMBER(tcr_el1_t1sz)") && nd->arch_data2) { > + if (STREQ(key, "NUMBER(TCR_EL1_T1SZ)") && nd->arch_data2) { > value = calloc(VADDR_PRLEN+1, sizeof(char)); > sprintf(value, "%lld", ((ulonglong)nd->arch_data2 >> 32) & 0xffffffff); > pc->read_vmcoreinfo = no_vmcoreinfo; > -- > 2.7.4

Hi Bhupesh, sorry for the late response. > -----Original Message----- > Update the Makefile comments to note that arm and arm64 > are also supported build targets. > > Signed-off-by: Bhupesh Sharma <bhsharma(a)redhat.com&gt; > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 745541012f43..7062139e68bc 100644 > --- a/Makefile > +++ b/Makefile > @@ -20,7 +20,7 @@ > PROGRAM=crash > > # > -# Supported targets: X86 ALPHA PPC IA64 PPC64 SPARC64 > +# Supported targets: X86 ALPHA ARM ARM64 PPC IA64 PPC64 SPARC64 Hmm, what does this "Supported targets" mean here? If it's the architectures that crash supports, then there is lack (x86_64, mips and so on). If it's the architectures that crash on x86_64 supports, then it's not correct, e.g. alpha dumpfiles are not supported on x86_64 crash.

And we usually use "make target=xxx" to set this TARGET, not write it here directly.

So I think this list is a bit confusing now, and I'd prefer to replace it with something like "For supported targets, see README." The README file explains the supported architectures and usage of "make target=xxx". How about this?

> # TARGET and GDB_CONF_FLAGS will be configured automatically by configure > # > TARGET= > -- > 2.7.4