Date: Thu, 19 Sep 2024 01:23:05 -0000 From: qiwu.chen(a)transsion.com Subject: [Crash-utility] Re: [PATCH v2] kmem: fix the determination for slab page To: devel(a)lists.crash-utility.osci.io Message-ID: <20240919012305.29184.37668(a)lists.crash-utility.osci.io&gt; Content-Type: text/plain; charset="utf-8" Hi Lianbo, Thanks for your review! > > Can you try to dump the values of the above two variables from > the dump_vm_table() and dump_offset_table()? We can display their values by > help -v and help -o options. > Sure, I will post patch v3 to display the two variables. > > > When initializing the page_page_type, the above "if" check seems to be > redundant. > Okay, it should be removed. >

> > Can this page_type_init() be moved to the page_flags_init()? > I don't think so, because the page type is an independent field of struct page which has different usage compared with page flags. What do other reviewers think?

Thanks Qiwu