8:28 a.m.
----- "Sharyathi Nagesh" <sharyath(a)in.ibm.com> wrote:
Hi Dave
As you may be aware dev -p command post linux kernel 2.6.25 fails with
"no PCI devices found on this system.". When I went through the kernel
a specific commit has removed pci_devices variable from the kernel code
==================================================================
git commit: 5ff580c10ec06fd296bd23d4570c1a95194094a0
by Greg Kroah-Hartman <gregkh(a)suse.de>
This is what he says in the commit
------------------------------------------------------------------------------------------------------------
This patch finally removes the global list of PCI devices. We are
relying entirely on the list held in the driver core now, and do not
need a separate "shadow" list as no one uses it.
------------------------------------------------------------------------------------------------------------
==================================================================
I saw some of your earlier postings where you have specifically mentioned about this
problem:
http://www.mail-archive.com/crash-utility@redhat.com/msg00346.html
With this I wanted to know, if you intend to keep dev -p behavior as it is now or
there is any plan to change it to display actual values?
Thank You
Sharyathi N
I (personally) have no plans to change it. If I remember correctly,
Bud Brown came up with an alternate scheme, but the imported data from
the kernel proper required to accomplish it was enormous (bordering
on absurd), so I suggested that it would be more appropriate as an
extension module.
Bud -- feel free to chime in here... ;-)
For that matter, even the "old" way required the import of ~1000 lines
of kernel #define's -- which always bugged me -- and was pretty much the
only crash command that had to do such a thing.
Dave
9:31 a.m.
New subject: dev -p command fails post linux 2.6.25
----- "Dave Anderson" <anderson(a)redhat.com> wrote:
> With this I wanted to know, if you intend to keep dev -p
behavior as it is now or
> there is any plan to change it to display actual values?
>
> Thank You
> Sharyathi N
I (personally) have no plans to change it. If I remember correctly,
Bud Brown came up with an alternate scheme, but the imported data from
the kernel proper required to accomplish it was enormous (bordering
on absurd), so I suggested that it would be more appropriate as an
extension module.
Bud -- feel free to chime in here... ;-)
For that matter, even the "old" way required the import of ~1000 lines
of kernel #define's -- which always bugged me -- and was pretty much the
only crash command that had to do such a thing.
Dave
Actually, at a minimum, I should change this:
if (!symbol_exists("pci_devices"))
error(FATAL, "no PCI devices found on this system.\n");
to the generic option_not_supported() message.
Dave
6:06 a.m.
New subject: dev -p command fails post linux 2.6.25
Thanks for the reply Dave.
Even I feel it is better to change the error message to what you have
suggested. That is simplest way to address the issue as well. It gives a
clearer message to the user.
I am curious to hear from Bud on the alternate scheme and progress
as well. Bud your views ?
Thanks
Sharyathi
On 04/23/2010 08:01 PM, Dave Anderson wrote:
----- "Dave Anderson" <anderson(a)redhat.com> wrote:
>> With this I wanted to know, if you intend to keep dev -p behavior
>> as it is now or there is any plan to change it to display actual
>> values?
>>
>> Thank You Sharyathi N
>
> I (personally) have no plans to change it. If I remember
> correctly, Bud Brown came up with an alternate scheme, but the
> imported data from the kernel proper required to accomplish it was
> enormous (bordering on absurd), so I suggested that it would be
> more appropriate as an extension module.
>
> Bud -- feel free to chime in here... ;-)
>
> For that matter, even the "old" way required the import of ~1000
> lines of kernel #define's -- which always bugged me -- and was
> pretty much the only crash command that had to do such a thing.
>
> Dave
Actually, at a minimum, I should change this:
if (!symbol_exists("pci_devices")) error(FATAL, "no PCI devices found
on this system.\n");
to the generic option_not_supported() message.
Dave
5:59 a.m.
New subject: dev -p command fails post linux 2.6.25
Dave
Actually, at a minimum, I should change this:
if (!symbol_exists("pci_devices")) error(FATAL, "no PCI devices found
on this system.\n");
to the generic option_not_supported() message.
Can you accept this change I basically replaced above error message to
option_not_supported() call.
Do let me know your observation
Thanks
Sharyathi N
5343
days inactive
5361
days old
devel@lists.crash-utility.osci.io
3 comments
2 participants
participants (2)
-
Dave Anderson -
Sharyathi Nagesh