support for older gcc - Crash-utility - Crash Utility List Archives

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

support for older gcc

RE: [Crash-utility] modules and...

xencrash-0.2 and crash version...

Daniel Li

Thursday, 30 November 2006 Thu, 30 Nov '06

11:58 a.m.

It seems there is a regression in recent versions of crash which disabled the fix put into crash 4.0-3.9 to deal with the fact older version gcc was not providing enough debug info in vmlinux (see the email threads on Oct 4 and Oct 5). Is there any plan to add the fix back in? Thanks, Daniel

Reply

Show replies by date

Dave Anderson

Thursday, 30 November Thu, 30 Nov

12:51 p.m.

Daniel Li wrote:

It seems there is a regression in recent versions of crash which disabled the fix put into crash 4.0-3.9 to deal with the fact older version gcc was not providing enough debug info in vmlinux (see the email threads on Oct 4 and Oct 5). Is there any plan to add the fix back in?

Well, I can't put anything back in that was never removed. The relevant patch that went into 4.0-3.6 to deal with the pid_hash debuginfo missing from the vmlinux file was this: 1225,1226c1221,1235 < if (!(plen = get_array_length("pid_hash", NULL, sizeof(void *)))) < error(FATAL, "cannot determine pid_hash array dimensions\n"); ---

if (!(plen = get_array_length("pid_hash", NULL, sizeof(void *)))) { /* * Workaround for gcc omitting debuginfo data for pid_hash. */ if (enumerator_value("PIDTYPE_MAX", &value)) { if ((sp = next_symbol("pid_hash", NULL)) && (((sp->value - tt->pidhash_addr) / sizeof(void *)) < value)) error(WARNING, "possible pid_hash array mis-handling\n"); plen = (int)value; } else { error(WARNING, "cannot determine pid_hash array dimensions\n"); plen = 1; } }

...and that code's still there. Looking at the 4.0-3.9 changelog, I don't see anything that could have affected the pid_hash handling. The only "sample" 4.0.0-built dumpfile that I have is a 2.6.16 xen dumpfile, and it still works OK with the latest crash: crash> sys KERNEL: /usr/dumps/xen-2.6.16/vmlinux DUMPFILE: /usr/dumps/xen-2.6.16/vmcore CPUS: 2 DATE: Wed Oct 4 11:16:36 2006 UPTIME: 00:02:07 LOAD AVERAGE: 0.02, 0.02, 0.00 TASKS: 67 NODENAME: compute-3-5-vm7 RELEASE: 2.6.16.13-xen VERSION: #5 SMP Tue Sep 19 17:19:32 EDT 2006 MACHINE: x86_64 (2800 Mhz) MEMORY: 108 MB crash> whatis pid_hash <data variable, no debug info> pid_hash; crash> help -k | grep gcc_version gcc_version: 4.0.0 crash> Are you seeing either of those two "pid_hash array" warning messages in the patch above? What does "crash -d7" show? Dave

Reply

6570

days inactive

6570

days old

devel@lists.crash-utility.osci.io

Manage subscription

1 comments

2 participants

tags (0)

participants (2)

Daniel Li
Dave Anderson