Re: [Crash-utility] [PATCH] Fix "vm -M" option to properly display virtual memory data of the task
On Wed, Mar 15, 2023 at 8:22 PM Philipp Rudo <prudo(a)redhat.com> wrote:
> + if (IS_A_NUMBER(args[optind])) {
wouldn't it be easier to simply add
if (!IS_A_NUMBER(args[optind])) {
optind++;
continue;
}
instead of moving the whole body of the loop inside the if-block. Or
did I miss something?
Thank you for the comment, Philipp.
I saw the similar code style in the task.c, just followed these changes.
But anyway, the above changes also look better to me.
Thanks.
Lianbo
Attachments:
- attachment.html (text/html — 952 bytes)