Re: [Crash-utility] [RFC PATCH 1/1] crash: printk: add support for lockless ringbuffer
Hi John,
I can see Linux 5.10-rc1 finally got your lockless ringbuffer.
I tried your RFC patch for the crash utility, but it seems that there
are some changes in the structures from that point, e.g. the dict ring
has been removed.
Do you have any plan to update the patch for us?
I'm looking into the current ringbuffer implementation, but it would be
very helpful to us if you would update the patch.
and if you can update the patch,
diff --git a/defs.h b/defs.h
index d8eda5e..253fabb 100644
--- a/defs.h
+++ b/defs.h
@@ -1906,12 +1906,30 @@ struct offset_table { /* stash of
commonly-used offsets */
long rt_prio_array_queue;
long task_struct_rt;
long sched_rt_entity_run_list;
+ long log_seq;
please move the added members in the offset_table and size_table to
the end of the tables. We have to do so in order to keep previously
compiled extension modules working.
Thanks,
Kazu