4:03 a.m.
The patchset will add cross compilation and CI build
for crash-utility, includes four patches:
[1] [PATCH 1/4] sparc64: fix build failure
[2] [PATCH 2/4] gdb:disable building gdbserver in crash-utility
This will speed up crash building and save time, also avoid
some compilation issues, the [3] and [4] will benefit from
this one.
[3] [PATCH 3/4] Add cross compilation support
E.g: cross build crash-utility for aarch64 on X86_64
make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc`
or
make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc` warn
Note: there are still some limitations for cross
compilation because some dependency libs that are not
cross-compiled, for example: snappy, lzo, zstd
[4] [PATCH 4/4] Add ci-build.yml
Add a CI build and enable it on multiple arches, which can
check for compilation issues and also reduce some maintaince
workload.
Please refer to the result of CI build:
https://github.com/lian-bo/crash/actions/runs/13895225118
v1->v2:
[PATCH 0-3]: No changes, just rebased on gdb-16.2
[PATCH 4]: The gdb-16.2 has the dependency of gmp and mpfr libs, so need
to cross compile them before cross compile crash-utility.
Lianbo Jiang (3):
sparc64: fix build failure
gdb:disable building gdbserver in crash-utility
Add cross compilation support
lian-bo (1):
Add ci-build.yml
.github/workflows/ci-build.yml | 93 ++++++++++++++++++++++++++++++++++
Makefile | 50 +++++++++++++++++-
README | 5 ++
configure.c | 6 +++
defs.h | 2 +-
gdb-16.2.patch | 12 +++++
help.c | 5 ++
7 files changed, 170 insertions(+), 3 deletions(-)
create mode 100644 .github/workflows/ci-build.yml
--
2.47.1
4:03 a.m.
New subject: [PATCH v2 1/4] sparc64: fix build failure
The following biuld error is observed on sparc64:
...
defs.h:2592:54: error: expected statement before ‘)’ token
2592 | #define BOOL(ADDR) LOADER(bool) ((char *)(ADDR)))
| ^
sbitmap.c:425:35: note: in expansion of macro ‘BOOL’
425 | sc->round_robin = BOOL(sbitmap_buf +
OFFSET(sbitmap_round_robin));
| ^~~~
make[5]: *** [Makefile:395: sbitmap.o] Error 1
The round brackets are not paired, let's fix it.
Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com>
---
defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/defs.h b/defs.h
index dcf12985a783..4cf169c85144 100644
--- a/defs.h
+++ b/defs.h
@@ -2589,7 +2589,7 @@ DEF_LOADER(bool);
#define SHORT(ADDR) LOADER(short) ((char *)(ADDR))
#define UCHAR(ADDR) *((unsigned char *)((char *)(ADDR)))
#define VOID_PTR(ADDR) ((void *) (LOADER(pointer_t) ((char *)(ADDR))))
-#define BOOL(ADDR) LOADER(bool) ((char *)(ADDR)))
+#define BOOL(ADDR) LOADER(bool) ((char *)(ADDR))
#else
--
2.47.1
4:03 a.m.
New subject: [PATCH v2 2/4] gdb:disable building gdbserver in crash-utility
The gdbserver is unused in crash-utility, but it
is always built by default during crash building.
Let's disable gdbserver building to save some time.
There are several advantages, for example:
[1] speed up crash building and save time
[2] avoid some compilation issues
[3] the following cross compile and ci will benefit
from this.
In addition, this is harmless for the old compilation
methods.
Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com>
---
gdb-16.2.patch | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gdb-16.2.patch b/gdb-16.2.patch
index 053c2d1c10d9..ee9bd2bfa8cd 100644
--- a/gdb-16.2.patch
+++ b/gdb-16.2.patch
@@ -1879,3 +1879,15 @@
_rl_tracefp = 0;
return r;
}
+--- gdb-16.2/configure.orig
++++ gdb-16.2/configure
+@@ -3620,6 +3620,9 @@ case "${target}" in
+ ;;
+ esac
+
++#disable gdbserver build in crash-utility
++enable_gdbserver=no
++
+ # Only allow gdbserver on some systems.
+ if test -d ${srcdir}/gdbserver; then
+ if test x$enable_gdbserver = x; then
--
2.47.1
4:03 a.m.
New subject: [PATCH v2 3/4] Add cross compilation support
Currently, the cross compilation is not supported in
crash-utility, let's add this feature.
Tested(ubuntu-24.04) on: X86_64, X86, aarch64, s390x,
powerpc64, alpha, sparc64, mips, riscv64
E.g: cross build crash-utility for aarch64 on X86_64
make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc`
or
make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc` warn
Note: there are still some limitations for cross
compilation because some dependency libs that are not
cross-compiled, for example: snappy, lzo, zstd
Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com>
---
Makefile | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
README | 5 +++++
configure.c | 6 ++++++
help.c | 5 +++++
4 files changed, 64 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 4e80658aaf49..28d4b853a916 100644
--- a/Makefile
+++ b/Makefile
@@ -27,11 +27,57 @@ PROGRAM=crash
TARGET=
GDB_CONF_FLAGS=
-ARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e
s/sa110/arm/)
+# Supported arches for cross compilation: x86_64, x86, aarch64, s390x,
+# powerpc64, alpha, sparc64, mips, riscv64
+# E.g: cross compile crash-utility for aarch64 on X86_64
+# make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc`
+# or
+# make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc` warn
+#
+ifneq ($(CROSS_COMPILE),)
+ARCH := $(shell echo $(CROSS_COMPILE) | sed 's:^.*/::g' | cut -d- -f1)
+else
+ARCH := $(shell uname -m)
+endif
+
+ARCH := $(shell echo $(ARCH) | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e
s/sa110/arm/)
+
+CC = $(CROSS_COMPILE)gcc
+CXX = $(CROSS_COMPILE)g++
+HOSTCC = gcc
+
ifeq (${ARCH}, ppc64)
CONF_FLAGS = -m64
endif
+ifneq ($(CROSS_COMPILE),)
+ifeq (${ARCH}, x86_64)
+CONF_TARGET_ARCH := X86_64
+else ifeq (${ARCH}, aarch64)
+CONF_TARGET_ARCH := ARM64
+else ifeq (${ARCH}, s390x)
+CONF_TARGET_ARCH := S390X
+else ifeq (${ARCH}, powerpc64)
+CONF_TARGET_ARCH := PPC64
+else ifeq (${ARCH}, ppc64le)
+CONF_TARGET_ARCH := PPC64
+else ifeq (${ARCH}, alpha)
+CONF_TARGET_ARCH := ALPHA
+else ifeq (${ARCH}, i386)
+CONF_TARGET_ARCH := X86
+else ifeq (${ARCH}, mips)
+CONF_TARGET_ARCH := MIPS
+else ifeq (${ARCH}, sparc64)
+CONF_TARGET_ARCH := SPARC64
+else ifeq (${ARCH}, riscv64)
+CONF_TARGET_ARCH := RISCV64
+else
+$(error The current Arch(${ARCH}) does not support cross compilation)
+endif
+CONF_FLAGS += -DCONF_TARGET_ARCH=${CONF_TARGET_ARCH}
+CONF_FLAGS += -DGDB_TARGET_DEFAULT="\"GDB_CONF_FLAGS=--host=$(shell echo
$(CROSS_COMPILE) | sed -e 's:^.*/::g' -e 's/-$$//')\""
+endif
+
#
# GDB, GDB_FILES, GDB_OFILES and GDB_PATCH_FILES will be configured automatically by
configure
#
@@ -313,7 +359,7 @@ force:
make_configure: force
@rm -f configure
- @${CC} ${CONF_FLAGS} -o configure configure.c ${WARNING_ERROR} ${WARNING_OPTIONS}
+ @${HOSTCC} ${CONF_FLAGS} -o configure configure.c ${WARNING_ERROR} ${WARNING_OPTIONS}
clean: make_configure
@./configure ${CONF_TARGET_FLAG} -q -b
diff --git a/README b/README
index d7e7d9b97899..4ce55626e501 100644
--- a/README
+++ b/README
@@ -84,6 +84,11 @@
$ cd crash-8.0.6
$ make
+ To cross compile the crash utility for aarch64 on x86_64:
+ $ make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc`
+
+ Supported arches for cross compilation: x86_64, x86, aarch64, s390x, powerpc64, alpha,
sparc64, mips, riscv64
+
The initial build will take several minutes because the embedded gdb module
must be configured and built. Alternatively, the crash source RPM file
may be installed and built, and the resultant crash binary RPM file installed.
diff --git a/configure.c b/configure.c
index 3386cdcbbe94..e0626318b8d5 100644
--- a/configure.c
+++ b/configure.c
@@ -169,7 +169,9 @@ void add_extra_lib(char *);
#define TARGET_CFLAGS_LOONGARCH64 "TARGET_CFLAGS="
#define TARGET_CFLAGS_LOONGARCH64_ON_X86_64 "TARGET_CFLAGS="
+#ifndef GDB_TARGET_DEFAULT
#define GDB_TARGET_DEFAULT "GDB_CONF_FLAGS="
+#endif
#define GDB_TARGET_ARM_ON_X86 "GDB_CONF_FLAGS=--target=arm-elf-linux"
#define GDB_TARGET_ARM_ON_X86_64 "GDB_CONF_FLAGS=--target=arm-elf-linux CFLAGS=-m32
CXXFLAGS=-m32"
#define GDB_TARGET_X86_ON_X86_64 "GDB_CONF_FLAGS=--target=i686-pc-linux-gnu
CFLAGS=-m32 CXXFLAGS=-m32"
@@ -386,6 +388,7 @@ get_current_configuration(struct supported_gdb_version *sp)
static char buf[512];
char *p;
+#ifndef CONF_TARGET_ARCH
#ifdef __alpha__
target_data.target = ALPHA;
#endif
@@ -432,6 +435,9 @@ get_current_configuration(struct supported_gdb_version *sp)
#ifdef __loongarch64
target_data.target = LOONGARCH64;
#endif
+#else
+ target_data.target = CONF_TARGET_ARCH;
+#endif
set_initial_target(sp);
diff --git a/help.c b/help.c
index 87eb9eed2eef..c1d8eca44f22 100644
--- a/help.c
+++ b/help.c
@@ -9618,6 +9618,11 @@ char *README[] = {
README_ENTER_DIRECTORY,
" $ make",
"",
+" To cross compile the crash utility for aarch64 on x86_64: ",
+" $ make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc`",
+"",
+" Supported arches for cross compilation: x86_64, x86, aarch64, s390x, powerpc64,
alpha, sparc64, mips, riscv64",
+"",
" The initial build will take several minutes because the embedded gdb
module",
" must be configured and built. Alternatively, the crash source RPM file",
" may be installed and built, and the resultant crash binary RPM file
installed.",
--
2.47.1
4:03 a.m.
New subject: [PATCH v2 4/4] Add ci-build.yml
From: lian-bo <lijiang(a)redhat.com>
Enable ci build on arches:
x86_64, x86, aarch64, s390x, powerpc64, alpha, sparc64, mips, riscv64
Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com>
---
.github/workflows/ci-build.yml | 93 ++++++++++++++++++++++++++++++++++
1 file changed, 93 insertions(+)
create mode 100644 .github/workflows/ci-build.yml
diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
new file mode 100644
index 000000000000..681f104ab1e4
--- /dev/null
+++ b/.github/workflows/ci-build.yml
@@ -0,0 +1,93 @@
+name: Build
+
+on:
+ push:
+ branches: [ "master" ]
+
+jobs:
+ build:
+ name: Build
+ runs-on: ubuntu-24.04
+ strategy:
+ matrix:
+ arch:
+ - x86_64
+ - aarch64
+ - s390x
+ - powerpc64
+ - x86
+ - riscv64
+ - mips
+ - alpha
+ - sparc64
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+
+ - name: Set Environment
+ env:
+ ARCH: ${{ matrix.arch }}
+ run: |
+ case $ARCH in
+ x86) GNU_ARCH="i686-linux-gnu" ;;
+ x86_64) CROSS_COMPILER_PKG="gcc-x86-64-linux-gnu"
+ CROSS_COMPILER_PKG+=" g++-x86-64-linux-gnu"
+ GNU_ARCH="$ARCH-linux-gnu" ;;
+ *) GNU_ARCH="$ARCH-linux-gnu" ;;
+ esac
+
+ if [ -n "$GNU_ARCH" ]; then
+ if [ -z "$CROSS_COMPILER_PKG" ]; then
+ CROSS_COMPILER_PKG="gcc-$GNU_ARCH"
+ CROSS_COMPILER_PKG+=" g++-$GNU_ARCH"
+ fi
+ EXTRA_PKGS+=" $CROSS_COMPILER_PKG"
+ CROSS_COMPILE="$GNU_ARCH"
+ fi
+
+ echo "EXTRA_PKGS=$EXTRA_PKGS" >> $GITHUB_ENV
+ echo "CROSS_COMPILE=$CROSS_COMPILE" >> $GITHUB_ENV
+
+ - name: Install deps for crash-utility building
+ run: |
+ sudo apt-get update
+ sudo apt-get install make gcc g++ bison flex texinfo wget patch tar
build-essential libc-dev autoconf automake libncurses-dev
+
+ - name: Install corss compile tool pkgs
+ if: env.EXTRA_PKGS != ''
+ run: |
+ sudo apt-get update
+ sudo apt-get -q=2 install ${{ env.EXTRA_PKGS }}
+
+ - name: Cross compile gmp lib
+ run: |
+ mkdir $GITHUB_WORKSPACE/libtools
+ wget https://gcc.gnu.org/pub/gcc/infrastructure/gmp-6.2.1.tar.bz2
+ tar -jxvf gmp-6.2.1.tar.bz2
+ cd gmp-6.2.1
+ ./configure --host=${{ env.CROSS_COMPILE }} --prefix=$GITHUB_WORKSPACE/libtools
+ make -j`nproc`
+ sudo make install
+ cd ..
+ - name: Cross compile mpfr lib
+ run: |
+ wget https://gcc.gnu.org/pub/gcc/infrastructure/mpfr-4.1.0.tar.bz2
+ tar -jxvf mpfr-4.1.0.tar.bz2
+ cd mpfr-4.1.0
+ ./configure --host=${{ env.CROSS_COMPILE }} --prefix=$GITHUB_WORKSPACE/libtools
--with-gmp=$GITHUB_WORKSPACE/libtools
+ make -j`nproc`
+ sudo make install
+ cd ..
+ - name: Cross compile crash-utility
+ run: |
+ sudo cp $GITHUB_WORKSPACE/libtools/include/* /usr/include/
+ sudo cp -r $GITHUB_WORKSPACE/libtools/lib/* /usr/lib/
+ sudo ldconfig -n /usr/lib/
+ make CROSS_COMPILE=${{ env.CROSS_COMPILE }}- -j"$(nproc)" warn
+ - name: Checking and Clean up
+ run: |
+ echo "Run command: file crash ..."
+ file crash
+ echo "Clean up for compiling ..."
+ make CROSS_COMPILE=${{ env.CROSS_COMPILE }}- -j"$(nproc)" clean
--
2.47.1
2:32 a.m.
Thanks for the review, Tao.
On Thu, Mar 20, 2025 at 1:16 PM Tao Liu <ltao(a)redhat.com> wrote:
Applied(with a minor change):
[1]
https://github.com/crash-utility/crash/commit/bc1fc6ac218cdca8d0259832e0d...
[2]
https://github.com/crash-utility/crash/commit/3115791c6894802b5f590c7a97f...
[3]
https://github.com/crash-utility/crash/commit/1248bfa806020abbbde5f52e925...
[4]
https://github.com/crash-utility/crash/commit/a312f58feb05bf86c78d2a10ee0...
Thanks
Lianbo
21
days inactive
24
days old
devel@lists.crash-utility.osci.io
7 comments
3 participants
participants (3)
-
Lianbo Jiang -
lijiang
-
Tao Liu