On 3/8/24 11:18, Ming Wang wrote: Thanks for the fix. The v2 looks good, so: Ack.

On 3/13/24 15:23, HAGIO KAZUHITO(萩尾 一仁) wrote: Hi, Kazu Thank you very much for the patch. Following your steps, I have the same errors here. Before apply Kazu patch: wangming@crazy:~/gerrit/crash_upstream$ git am 0001-LoongArch64-Fixed-link-errors-when-build-on-LOONGARC.patch Applying: LoongArch64: Fixed link errors when build on LOONGARCH64 machine wangming@crazy:~/gerrit/crash_upstream$ make -j 32 warn target=LOONGARCH64 There are some compilation errors, --- cpu-loongarch.c:86:33: error: redefinition of ‘bfd_loongarch32_arch’    86 | static const bfd_arch_info_type bfd_loongarch32_arch =       |                                 ^~~~~~~~~~~~~~~~~~~~ cpu-loongarch.c:25:33: note: previous definition of ‘bfd_loongarch32_arch’ with type ‘bfd_arch_info_type’ {aka ‘const struct bfd_arch_info’}    25 | static const bfd_arch_info_type bfd_loongarch32_arch =       |                                 ^~~~~~~~~~~~~~~~~~~~ cpu-loongarch.c:104:26: error: redefinition of ‘bfd_loongarch_arch’   104 | const bfd_arch_info_type bfd_loongarch_arch =       |                          ^~~~~~~~~~~~~~~~~~ cpu-loongarch.c:43:26: note: previous definition of ‘bfd_loongarch_arch’ with type ‘bfd_arch_info_type’ {aka ‘const struct bfd_arch_info’}    43 | const bfd_arch_info_type bfd_loongarch_arch =       |                          ^~~~~~~~~~~~~~~~~~ make[7]: *** [Makefile:1611: cpu-loongarch.lo] Error 1 make[7]: *** Waiting for unfinished jobs.... elfxx-loongarch.c:1650:16: error: redefinition of ‘struct loongarch_reloc_howto_type_struct’  1650 | typedef struct loongarch_reloc_howto_type_struct       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ elfxx-loongarch.c:32:16: note: originally defined here    32 | typedef struct loongarch_reloc_howto_type_struct       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ elfxx-loongarch.c:1657:3: error: conflicting types for ‘loongarch_reloc_howto_type’; have ‘struct loongarch_reloc_howto_type_struct’  1657 | } loongarch_reloc_howto_type;       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~ --- After apply Kazu patch: wangming@crazy:~/gerrit/crash_upstream$ git am Kazu_patch/* Applying: gdb-10.2.patch: Fix duplicated code by re-applying patch Applying: LoongArch64: Fixed link errors when build on LOONGARCH64 machine wangming@crazy:~/gerrit/crash_upstream$ make -j 32 warn target=LOONGARCH64 No compilation errors, ---   CXX    tui/tui-hooks.o   CXX    tui/tui-source.o   CXX    tui/tui-winsource.o   CXX    valops.o   CXX    value.o   GEN    init.c gcc -c -g -DLOONGARCH64  -DGDB_10_2 -g -O2 build_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security ar -rs crashlib.a main.o tools.o global_data.o memory.o filesys.o help.o task.o build_data.o kernel.o test.o gdb_interface.o net.o dev.o bpf.o printk.o alpha.o x86.o ppc.o ia64.o s390.o s390x.o s390dbf.o ppc64.o x86_64.o arm.o arm64.o mips.o mips64.o riscv64.o loongarch64.o sparc64.o extensions.o remote.o va_server.o va_server_v1.o symbols.o cmdline.o lkcd_common.o lkcd_v1.o lkcd_v2_v3.o lkcd_v5.o lkcd_v7.o lkcd_v8.o lkcd_fix_mem.o s390_dump.o netdump.o diskdump.o makedumpfile.o xendump.o lkcd_x86_trace.o unwind_v1.o unwind_v2.o unwind_v3.o unwind_x86_32_64.o unwind_arm.o xen_hyper.o xen_hyper_command.o xen_hyper_global_data.o xen_hyper_dump_tables.o kvmdump.o qemu.o qemu-load.o sadump.o ipcs.o ramdump.o vmware_vmss.o vmware_guestdump.o xen_dom0.o kaslr_helper.o sbitmap.o maple_tree.o   CXXLD  gdb --- I'm very sorry that I didn't find the issue introduced by my patch before. Thanks, Ming