Re: [Crash-utility] [PATCH v2 0/4] sadump, kaslr: fix failure of calculating kaslr_offset due to an sadump format restriction

在 2020年07月29日 08:33, HAGIO KAZUHITO(萩尾　一仁) 写道: > Hi Hatayama-san, > > Thank you for the new series, it looks good to me. > > For the v2 series, > Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt; > > Bhupesh, Lianbo, could either of you review this series? > Hi, Hatayama-san, Kazu Sorry for the delay. Ack the v2 series. But, seems that it has some style issues in the fourth patch [PATCH v2 4/4], for example: "ERROR: code indent should use tabs where possible" Would you mind correcting the above code style issues when merging the fourth patch? Thank you in advance, Kazu.

BTW: we could check it with the scripts/checkpatch.pl. Thanks. Lianbo > Thanks, > Kazu > > -----Original Message----- >> This patch series fix failure of calculating kaslr_offset due to an >> sadump format restriction. >> >> The main part is the 4-th patch. I found some small bugs during this >> work and the 2nd and 3rd are to fix them and are also needed for the >> 4-th patch. >> >> This issue occurs also in makedumpfile, and I have already posted the >> corresponding patch for makedumpfile at: >> >> http://lists.infradead.org/pipermail/kexec/2020-July/020852.html >> >> ChangeLog: >> v1=>v2: >> - Add Signed-off-by: in each commit description >> - 4/4: Remove unused zero variable in get_sadump_smram_cpu_state_any() >> - 2/4: Fix mismatch of the symbol name and the member of the symbol table >> >> HATAYAMA Daisuke (4): >> symbols: Add linux_banner_vmlinux in symbol table >> symbols: fix initialization of st->{pti_init,kaiser}_vmlinux >> kaslr: cleanup how to set values to the arguments of >> calc_kaslr_offset() >> kaslr: fix failure of calculating kaslr_offset due to an sadump format >> restriction >> >> defs.h | 1 + >> kaslr_helper.c | 61 +++++++++++++++++++++++++++++++++++++++++++++------------- >> sadump.c | 20 +++++++++++-------- >> symbols.c | 25 +++++++++++++++++++----- >> 4 files changed, 81 insertions(+), 26 deletions(-) >> >> -- >> 1.8.3.1 >