[Crash-utility] Re: [PATCH] Fix compiler warnings on s390(x)
Michael Holzheu wrote:
Hi Dave!
This patch fixes all warnings (gcc 4.1.0) on s390 and s390x.
This allows us to build crash with "make Warn" now.
Michael
Ok, thanks, I've got these in place.
One thing that I noticed, and that I've added to your patch, is this:
diff -r1.264 defs.h
2410c2410
< #define IS_VMALLOC_ADDR(X) (vt->vmalloc_start && (ulong)(X) >=
vt->vmalloc_start)
---
#define IS_VMALLOC_ADDR(X) s390x_IS_VMALLOC_ADDR(X)
It seems that s390x_IS_VMALLOC_ADDR() was created but never
put in place for IS_VMALLOC_ADDR() to use.
Let me know if that's not correct.
Thanks again,
Dave