[Crash-utility] Re: [PATCH] vmware_guestdump: Various format versions support

Hi Lianbo, Tao, Could this patch have one more ack from either of you?

Thanks, Kazu On 2024/03/08 10:41, Alexey Makhalov wrote: > Ouh, yes please do it. This is the right change. Thanks Kazu. --Alexey > > On Thu, Mar 7, 2024 at 12:12 AM HAGIO KAZUHITO(萩尾　一仁) > <k-hagio-ab(a)nec.com <mailto:k-hagio-ab@nec.com>> wrote: > > On 2024/03/05 10:44, Alexey Makhalov wrote: > > There are several versions of debug.guest format. Current version of > > the code is able to parse only version 4. > > > > Improve parser to support other known versions. Split data structures > > on sub-structures and introduce a helper functions to calculate a gap > > between them based on the version number. Implement additional data > > structure (struct mainmeminfo_old) and logic specifically for > original > > (version 1) format support. > > > > Signed-off-by: Alexey Makhalov <alexey.makhalov(a)broadcom.com > <mailto:alexey.makhalov@broadcom.com>> > > This warning is emitted: > > $ make clean ; make warn > > cc -c -g -DX86_64 -DLZO -DSNAPPY -DZSTD -DGDB_10_2 > vmware_guestdump.c -Wall -O2 -Wstrict-prototypes > -Wmissing-prototypes -fstack-protector -Wformat-security > vmware_guestdump.c: In function 'is_vmware_guestdump': > vmware_guestdump.c:290:1: warning: label 'unrecognized' defined but > not used [-Wunused-label] > unrecognized: > ^~~~~~~~~~~~ > > Is it OK to just remove this label and the following code? > > --- a/vmware_guestdump.c > +++ b/vmware_guestdump.c > @@ -286,11 +286,6 @@ is_vmware_guestdump(char *filename) > vmss.memoffset = 0; > vmss.num_vcpus = hdr.num_vcpus; > return TRUE; > - > -unrecognized: > - if (CRASHDEBUG(1)) > - error(INFO, LOGPRX"Unrecognized debug.guest file.\n"); > - return FALSE; > } > > int > > If so, we can do it when applying, > > Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com > <mailto:k-hagio-ab@nec.com>> > > Thanks, > Kazu -- Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki