2:28 a.m.
The search command currently fails on RISC-V based vmcores
without providing specific details, only printing a generic 'invalid' message.
This patch enhances the debug output by including the specific virtual address
(before)
crash> search ffffffd8c2b42280
invalid
(after)
crash> search ffffffd8c2b42280
invalid for ffffffd800000000 address
Signed-off-by: Austin Kim <austindh.kim(a)gmail.com>
---
riscv64.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/riscv64.c b/riscv64.c
index eceae70..ee9d4e3 100644
--- a/riscv64.c
+++ b/riscv64.c
@@ -687,7 +687,7 @@ riscv64_vtop_3level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr, int
verbose)
return TRUE;
no_page:
- fprintf(fp, "invalid\n");
+ fprintf(fp, "invalid for %lx address\n", vaddr);
return FALSE;
}
@@ -1279,7 +1279,7 @@ riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr,
int verbose)
return TRUE;
no_page:
- fprintf(fp, "invalid\n");
+ fprintf(fp, "invalid for %lx address\n", vaddr);
return FALSE;
}
@@ -1368,7 +1368,7 @@ riscv64_vtop_5level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr,
int verbose)
return TRUE;
no_page:
- fprintf(fp, "invalid\n");
+ fprintf(fp, "invalid for %lx address\n", vaddr);
return FALSE;
}
--
2.34.1
11:44 p.m.
2026년 3월 31일 (화) 오후 4:28, Austin Kim <austindh.kim(a)gmail.xn--com>-4f21ay07k 작성:
The search command currently fails on RISC-V based vmcores
without providing specific details, only printing a generic 'invalid' message.
This patch enhances the debug output by including the specific virtual address
(before)
crash> search ffffffd8c2b42280
invalid
(after)
crash> search ffffffd8c2b42280
invalid for ffffffd800000000 address
Signed-off-by: Austin Kim <austindh.kim(a)gmail.com>
---
riscv64.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/riscv64.c b/riscv64.c
index eceae70..ee9d4e3 100644
--- a/riscv64.c
+++ b/riscv64.c
@@ -687,7 +687,7 @@ riscv64_vtop_3level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr,
int verbose)
return TRUE;
no_page:
- fprintf(fp, "invalid\n");
+ fprintf(fp, "invalid for %lx address\n", vaddr);
return FALSE;
}
@@ -1279,7 +1279,7 @@ riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr,
int verbose)
return TRUE;
no_page:
- fprintf(fp, "invalid\n");
+ fprintf(fp, "invalid for %lx address\n", vaddr);
return FALSE;
}
@@ -1368,7 +1368,7 @@ riscv64_vtop_5level_4k(ulong *pgd, ulong vaddr, physaddr_t *paddr,
int verbose)
return TRUE;
no_page:
- fprintf(fp, "invalid\n");
+ fprintf(fp, "invalid for %lx address\n", vaddr);
return FALSE;
}
Hello,
If you are available, would you please give me any feedback?
BR,
Austin Kim
>
> --
> 2.34.1
>
4:18 a.m.
New subject: [PATCH v2] RISC-V: improve error message for search command failure
Hi Austin,
Sorry for the late reply. For the v2 LGTM, ack.
Thanks,
Tao Liu
On Mon, Apr 13, 2026 at 4:45 PM Austin Kim <austindh.kim(a)gmail.com> wrote:
2026년 3월 31일 (화) 오후 4:28, Austin Kim <austindh.kim(a)gmail.xn--com>-4f21ay07k 작성:
>
> The search command currently fails on RISC-V based vmcores
> without providing specific details, only printing a generic 'invalid'
message.
> This patch enhances the debug output by including the specific virtual address
>
> (before)
> crash> search ffffffd8c2b42280
> invalid
>
> (after)
> crash> search ffffffd8c2b42280
> invalid for ffffffd800000000 address
>
> Signed-off-by: Austin Kim <austindh.kim(a)gmail.com>
> ---
> riscv64.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/riscv64.c b/riscv64.c
> index eceae70..ee9d4e3 100644
> --- a/riscv64.c
> +++ b/riscv64.c
> @@ -687,7 +687,7 @@ riscv64_vtop_3level_4k(ulong *pgd, ulong vaddr, physaddr_t
*paddr, int verbose)
>
> return TRUE;
> no_page:
> - fprintf(fp, "invalid\n");
> + fprintf(fp, "invalid for %lx address\n", vaddr);
> return FALSE;
> }
>
> @@ -1279,7 +1279,7 @@ riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr, physaddr_t
*paddr, int verbose)
>
> return TRUE;
> no_page:
> - fprintf(fp, "invalid\n");
> + fprintf(fp, "invalid for %lx address\n", vaddr);
> return FALSE;
> }
>
> @@ -1368,7 +1368,7 @@ riscv64_vtop_5level_4k(ulong *pgd, ulong vaddr, physaddr_t
*paddr, int verbose)
>
> return TRUE;
> no_page:
> - fprintf(fp, "invalid\n");
> + fprintf(fp, "invalid for %lx address\n", vaddr);
> return FALSE;
> }
Hello,
If you are available, would you please give me any feedback?
BR,
Austin Kim
>
> --
> 2.34.1
>
--
Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
11:33 p.m.
New subject: [PATCH v2] RISC-V: improve error message for search command failure
applied:
https://github.com/crash-utility/crash/commit/ff063ed0df6c99675b060cdbe1c...
On Mon, Apr 13, 2026 at 9:18 PM Tao Liu <ltao(a)redhat.com> wrote:
Hi Austin,
Sorry for the late reply. For the v2 LGTM, ack.
Thanks,
Tao Liu
On Mon, Apr 13, 2026 at 4:45 PM Austin Kim <austindh.kim(a)gmail.com> wrote:
>
> 2026년 3월 31일 (화) 오후 4:28, Austin Kim <austindh.kim(a)gmail.xn--com>-4f21ay07k 작성:
> >
> > The search command currently fails on RISC-V based vmcores
> > without providing specific details, only printing a generic 'invalid'
message.
> > This patch enhances the debug output by including the specific virtual address
> >
> > (before)
> > crash> search ffffffd8c2b42280
> > invalid
> >
> > (after)
> > crash> search ffffffd8c2b42280
> > invalid for ffffffd800000000 address
> >
> > Signed-off-by: Austin Kim <austindh.kim(a)gmail.com>
> > ---
> > riscv64.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/riscv64.c b/riscv64.c
> > index eceae70..ee9d4e3 100644
> > --- a/riscv64.c
> > +++ b/riscv64.c
> > @@ -687,7 +687,7 @@ riscv64_vtop_3level_4k(ulong *pgd, ulong vaddr, physaddr_t
*paddr, int verbose)
> >
> > return TRUE;
> > no_page:
> > - fprintf(fp, "invalid\n");
> > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > return FALSE;
> > }
> >
> > @@ -1279,7 +1279,7 @@ riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr,
physaddr_t *paddr, int verbose)
> >
> > return TRUE;
> > no_page:
> > - fprintf(fp, "invalid\n");
> > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > return FALSE;
> > }
> >
> > @@ -1368,7 +1368,7 @@ riscv64_vtop_5level_4k(ulong *pgd, ulong vaddr,
physaddr_t *paddr, int verbose)
> >
> > return TRUE;
> > no_page:
> > - fprintf(fp, "invalid\n");
> > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > return FALSE;
> > }
>
> Hello,
>
> If you are available, would you please give me any feedback?
>
> BR,
> Austin Kim
>
> >
> > --
> > 2.34.1
> >
> --
> Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
> To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
> https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> Contribution Guidelines: https://github.com/crash-utility/crash/wiki
>
11:46 p.m.
New subject: [PATCH v2] RISC-V: improve error message for search command failure
2026년 4월 24일 (금) 오후 1:33, Tao Liu <ltao(a)redhat.xn--com>-4f21ay07k 작성:
Great, thank you.
BR,
Austin Kim
> On Mon, Apr 13, 2026 at 9:18 PM Tao Liu <ltao(a)redhat.com> wrote:
> >
> > Hi Austin,
> >
> > Sorry for the late reply. For the v2 LGTM, ack.
> >
> > Thanks,
> > Tao Liu
> >
> > On Mon, Apr 13, 2026 at 4:45 PM Austin Kim <austindh.kim(a)gmail.com>
wrote:
> > >
> > > 2026년 3월 31일 (화) 오후 4:28, Austin Kim <austindh.kim(a)gmail.xn--com>-4f21ay07k 작성:
> > > >
> > > > The search command currently fails on RISC-V based vmcores
> > > > without providing specific details, only printing a generic
'invalid' message.
> > > > This patch enhances the debug output by including the specific virtual
address
> > > >
> > > > (before)
> > > > crash> search ffffffd8c2b42280
> > > > invalid
> > > >
> > > > (after)
> > > > crash> search ffffffd8c2b42280
> > > > invalid for ffffffd800000000 address
> > > >
> > > > Signed-off-by: Austin Kim <austindh.kim(a)gmail.com>
> > > > ---
> > > > riscv64.c | 6 +++---
> > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/riscv64.c b/riscv64.c
> > > > index eceae70..ee9d4e3 100644
> > > > --- a/riscv64.c
> > > > +++ b/riscv64.c
> > > > @@ -687,7 +687,7 @@ riscv64_vtop_3level_4k(ulong *pgd, ulong vaddr,
physaddr_t *paddr, int verbose)
> > > >
> > > > return TRUE;
> > > > no_page:
> > > > - fprintf(fp, "invalid\n");
> > > > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > > > return FALSE;
> > > > }
> > > >
> > > > @@ -1279,7 +1279,7 @@ riscv64_vtop_4level_4k(ulong *pgd, ulong vaddr,
physaddr_t *paddr, int verbose)
> > > >
> > > > return TRUE;
> > > > no_page:
> > > > - fprintf(fp, "invalid\n");
> > > > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > > > return FALSE;
> > > > }
> > > >
> > > > @@ -1368,7 +1368,7 @@ riscv64_vtop_5level_4k(ulong *pgd, ulong vaddr,
physaddr_t *paddr, int verbose)
> > > >
> > > > return TRUE;
> > > > no_page:
> > > > - fprintf(fp, "invalid\n");
> > > > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > > > return FALSE;
> > > > }
> > >
> > > Hello,
> > >
> > > If you are available, would you please give me any feedback?
> > >
> > > BR,
> > > Austin Kim
> > >
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > > --
> > > Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
> > > To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
> > > https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> > > Contribution Guidelines: https://github.com/crash-utility/crash/wiki
> > >
>
39
days inactive
63
days old
devel@lists.crash-utility.osci.io
4 comments
2 participants
participants (2)
-
Austin Kim -
Tao Liu