1:40 a.m.
Hi, Alexander
Thank you for the early fix.
On 4/10/24 22:15, devel-request(a)lists.crash-utility.osci.io wrote:
Date: Wed, 10 Apr 2024 14:55:35 +0200
From: Alexander Gordeev<agordeev(a)linux.ibm.com>
Subject: [Crash-utility] [PATCH] Reflect __{start,end}_init_task
kernel symbols rename
To:devel@lists.crash-utility.osci.io
Cc: Alexander Egorenkov<egorenar(a)linux.ibm.com>
Message-ID:<20240410125535.2891355-1-agordeev@linux.ibm.com>
Kernel commit 8f69cba096b5 ("x86: Rename __{start,end}_init_task to
__{start,end}_init_stack") leads to failure:
crash: invalid count request: 0
Could you please point out which command caused the current failure? or
failed when crash load?
Anyway, the code changes are fine to me.
Thanks
Lianbo
Assume both __{start,end}_init_task and __{start,end}_init_stack
symbols could exist for backward compatibility.
Signed-off-by: Alexander Gordeev<agordeev(a)linux.ibm.com>
---
task.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/task.c b/task.c
index ebdb5be..88e1d50 100644
--- a/task.c
+++ b/task.c
@@ -496,10 +496,17 @@ task_init(void)
((len = SIZE(thread_union)) != STACKSIZE())) {
machdep->stacksize = len;
} else if (!VALID_SIZE(thread_union) && !VALID_SIZE(task_union)) {
+ len = 0;
if (kernel_symbol_exists("__start_init_task") &&
kernel_symbol_exists("__end_init_task")) {
len = symbol_value("__end_init_task");
len -= symbol_value("__start_init_task");
+ } else if (kernel_symbol_exists("__start_init_stack") &&
+ kernel_symbol_exists("__end_init_stack")) {
+ len = symbol_value("__end_init_stack");
+ len -= symbol_value("__start_init_stack");
+ }
+ if (len) {
ASSIGN_SIZE(thread_union) = len;
machdep->stacksize = len;
}
-- 2.40.1
2:23 a.m.
New subject: [PATCH] Reflect __{start,end}_init_task kernel symbols rename
On Mon, Apr 15, 2024 at 02:40:22PM +0800, Lianbo Jiang wrote:
Hi, Alexander
Thank you for the early fix.
...
> Kernel commit 8f69cba096b5 ("x86: Rename
__{start,end}_init_task to
> __{start,end}_init_stack") leads to failure:
>
> crash: invalid count request: 0
Could you please point out which command caused the current failure? or
failed when crash load?
It crashes on load.
Anyway, the code changes are fine to me.
Thanks
Lianbo
Thanks!
5:48 a.m.
New subject: [PATCH] Reflect __{start,end}_init_task kernel symbols rename
On Mon, Apr 15, 2024 at 3:23 PM Alexander Gordeev <agordeev(a)linux.ibm.com>
wrote:
On Mon, Apr 15, 2024 at 02:40:22PM +0800, Lianbo Jiang wrote:
> Hi, Alexander
>
> Thank you for the early fix.
...
> > Kernel commit 8f69cba096b5 ("x86: Rename __{start,end}_init_task to
> > __{start,end}_init_stack") leads to failure:
> >
> > crash: invalid count request: 0
>
> Could you please point out which command caused the current failure? or
> failed when crash load?
It crashes on load.
Thank you for the feedback, Alexander.
Given that, I would suggest adding the following words to patch log when
merging this patch:
"... failed to load with an error:"
crash: invalid count request: 0
So far I haven't seen the kernel commit 8f69cba096b5 in the mainline
branch. Once ready, we can apply this patch.
So: Ack
(Also wait for another ack.)
Thanks.
Lianbo
> Anyway, the code changes are fine to me.
>
>
> Thanks
>
> Lianbo
Thanks!
7:42 a.m.
New subject: [PATCH] Reflect __{start,end}_init_task kernel symbols rename
Hi Alexander,
The patch looks good to me, so ack.
Thanks,
Tao Liu
On Mon, Apr 15, 2024 at 2:41 PM Lianbo Jiang <lijiang(a)redhat.com> wrote:
Hi, Alexander
Thank you for the early fix.
On 4/10/24 22:15, devel-request(a)lists.crash-utility.osci.io wrote:
> Date: Wed, 10 Apr 2024 14:55:35 +0200
> From: Alexander Gordeev<agordeev(a)linux.ibm.com>
> Subject: [Crash-utility] [PATCH] Reflect __{start,end}_init_task
> kernel symbols rename
> To:devel@lists.crash-utility.osci.io
> Cc: Alexander Egorenkov<egorenar(a)linux.ibm.com>
> Message-ID:<20240410125535.2891355-1-agordeev@linux.ibm.com>
>
> Kernel commit 8f69cba096b5 ("x86: Rename __{start,end}_init_task to
> __{start,end}_init_stack") leads to failure:
>
> crash: invalid count request: 0
Could you please point out which command caused the current failure? or
failed when crash load?
Anyway, the code changes are fine to me.
Thanks
Lianbo
> Assume both __{start,end}_init_task and __{start,end}_init_stack
> symbols could exist for backward compatibility.
>
> Signed-off-by: Alexander Gordeev<agordeev(a)linux.ibm.com>
> ---
> task.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/task.c b/task.c
> index ebdb5be..88e1d50 100644
> --- a/task.c
> +++ b/task.c
> @@ -496,10 +496,17 @@ task_init(void)
> ((len = SIZE(thread_union)) != STACKSIZE())) {
> machdep->stacksize = len;
> } else if (!VALID_SIZE(thread_union) && !VALID_SIZE(task_union)) {
> + len = 0;
> if (kernel_symbol_exists("__start_init_task") &&
> kernel_symbol_exists("__end_init_task")) {
> len = symbol_value("__end_init_task");
> len -= symbol_value("__start_init_task");
> + } else if (kernel_symbol_exists("__start_init_stack")
&&
> + kernel_symbol_exists("__end_init_stack")) {
> + len = symbol_value("__end_init_stack");
> + len -= symbol_value("__start_init_stack");
> + }
> + if (len) {
> ASSIGN_SIZE(thread_union) = len;
> machdep->stacksize = len;
> }
> -- 2.40.1
--
Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
6:24 a.m.
New subject: [PATCH] Reflect __{start,end}_init_task kernel symbols rename
On Mon, Apr 15, 2024 at 8:43 PM Tao Liu <ltao(a)redhat.com> wrote:
Hi Alexander,
The patch looks good to me, so ack.
Thanks,
Tao Liu
On Mon, Apr 15, 2024 at 2:41 PM Lianbo Jiang <lijiang(a)redhat.com> wrote:
>
> Hi, Alexander
>
> Thank you for the early fix.
>
> On 4/10/24 22:15, devel-request(a)lists.crash-utility.osci.io wrote:
> > Date: Wed, 10 Apr 2024 14:55:35 +0200
> > From: Alexander Gordeev<agordeev(a)linux.ibm.com>
> > Subject: [Crash-utility] [PATCH] Reflect __{start,end}_init_task
> > kernel symbols rename
> > To:devel@lists.crash-utility.osci.io
> > Cc: Alexander Egorenkov<egorenar(a)linux.ibm.com>
> > Message-ID:<20240410125535.2891355-1-agordeev@linux.ibm.com>
> >
> > Kernel commit 8f69cba096b5 ("x86: Rename __{start,end}_init_task to
> > __{start,end}_init_stack") leads to failure:
> >
> > crash: invalid count request: 0
>
> Could you please point out which command caused the current failure? or
> failed when crash load?
>
>
> Anyway, the code changes are fine to me.
>
>
> Thanks
>
> Lianbo
>
> > Assume both __{start,end}_init_task and __{start,end}_init_stack
> > symbols could exist for backward compatibility.
> >
> > Signed-off-by: Alexander Gordeev<agordeev(a)linux.ibm.com>
> > ---
> > task.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
Currently kernel commit 8f69cba096b5 is in the linux master branch.
Applied:
https://github.com/crash-utility/crash/commit/3879e9104826d5ae14a0824ec47...
Thanks
Lianbo
> diff --git a/task.c b/task.c
> > index ebdb5be..88e1d50 100644
> > --- a/task.c
> > +++ b/task.c
> > @@ -496,10 +496,17 @@ task_init(void)
> > ((len = SIZE(thread_union)) != STACKSIZE())) {
> > machdep->stacksize = len;
> > } else if (!VALID_SIZE(thread_union) && !VALID_SIZE(task_union))
{
> > + len = 0;
> > if (kernel_symbol_exists("__start_init_task")
&&
> > kernel_symbol_exists("__end_init_task")) {
> > len = symbol_value("__end_init_task");
> > len -= symbol_value("__start_init_task");
> > + } else if (kernel_symbol_exists("__start_init_stack")
&&
> > + kernel_symbol_exists("__end_init_stack")) {
> > + len = symbol_value("__end_init_stack");
> > + len -= symbol_value("__start_init_stack");
> > + }
> > + if (len) {
> > ASSIGN_SIZE(thread_union) = len;
> > machdep->stacksize = len;
> > }
> > -- 2.40.1
40
days inactive
75
days old
devel@lists.crash-utility.osci.io
4 comments
4 participants
participants (4)
-
Alexander Gordeev -
Lianbo Jiang -
lijiang
-
Tao Liu