On 10/3/26 3:20 PM, Dave Young wrote:
On 10/3/26 1:32 PM, Dave Young wrote:
> Hi Boiko,
>
> I will review it. But please resend via either embed the patch in email body via
email client (not an attachment), or send it via git send-email.
Copy some comments here, but please make sure to send plain text inline patch as above
(use git send-email for safe if you are not sure how to setup email clients).
/* necessary header files */
typedef unsigned int u32;
+#if defined(X86_64) && !defined(__x86_64__)
+#include "lkcd_x86_64_pt_regs.h" /* for pt_regs
*/
+#else
#include <asm/ptrace.h> /* for pt_regs */
+#endif
Above chunk is unreachable. That #include sits inside below if condition:
#if defined(ARM) || defined(X86) || defined(PPC) || defined(S390) || \
defined(S390X) || defined(ARM64) || defined(MIPS) || \
defined(MIPS64) || defined(SPARC64) || defined(RISCV64) || \
defined(LOONGARCH64)
2. Remove TARGET_CFLAGS_X86_64_ON_ARM64 as it is identical to the TARGET_CFLAGS_X86_64
3. machine_type("X86") in filesys.c is unreachable: configure.c never allows
target=X86 on an arm64 host. Harmless defensive symmetry.
4. lkcd_x86_64_pt_regs.h: Copyright line is wrong (2025), please remove or update it.
5. below chunk is not for supporting x86_64 on arm64, please separate it in another
patch:
if ((target_data.initial_gdb_target == ARM64) &&
(target_data.target != ARM64)) {
- if (target_data.target == X86_64)
+ if ((target_data.target == X86_64) &&
+ (target_data.host == X86_64))
target_data.target = ARM64;
else
arch_mismatch(sp);
>
> On 10/2/26 10:33 PM, Boiko Alex wrote:
>>
>>
>>
>> --
>> Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
>> To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
>> https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
>> Contribution Guidelines:
https://github.com/crash-utility/crash/wiki
> --
> Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
> To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
> https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> Contribution Guidelines:
https://github.com/crash-utility/crash/wiki
--
Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines:
https://github.com/crash-utility/crash/wiki