Hi Austin,
On Thu, Mar 26, 2026 at 3:42 PM Austin Kim <austindh.kim(a)gmail.com> wrote:
Hello, Tao
2026년 3월 24일 (화) PM 1:29, Tao Liu <ltao(a)redhat.xn--com>-4f21ay07k 작성:
>
> Hi Austin,
>
> LGTM, ack.
Thank you for the positive feedback.
I guess it will be good to apply this debugging code to another
functions as well, as below:
- riscv64_vtop_5level_4k
- riscv64_vtop_4level_4k
I will send another version of the patch soon.
Sure, please do.
Thanks,
Tao Liu
BR,
Austin Kim
>
> Thanks,
> Tao Liu
>
> On Mon, Mar 23, 2026 at 6:38 PM Austin Kim <austindh.kim(a)gmail.com> wrote:
> >
> > The search command currently fails on RISC-V based vmcores
> > without providing specific details, only printing a generic 'invalid'
message.
> > This patch enhances the debug output by including the specific virtual address
> >
> > (before)
> > crash> search ffffffd8c2b42280
> > invalid
> >
> > (after)
> > crash> search ffffffd8c2b42280
> > invalid for ffffffd800000000 address
> >
> > Note: Work is in progress to fix the search command on RISC-V based vmcores.
> >
> > Signed-off-by: Austin Kim <austindh.kim(a)gmail.com>
> > ---
> > riscv64.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/riscv64.c b/riscv64.c
> > index eceae70..0b1aebd 100644
> > --- a/riscv64.c
> > +++ b/riscv64.c
> > @@ -687,7 +687,7 @@ riscv64_vtop_3level_4k(ulong *pgd, ulong vaddr, physaddr_t
*paddr, int verbose)
> >
> > return TRUE;
> > no_page:
> > - fprintf(fp, "invalid\n");
> > + fprintf(fp, "invalid for %lx address\n", vaddr);
> > return FALSE;
> > }
> >
> > --
> > 2.34.1
> > --
> > Crash-utility mailing list -- devel(a)lists.crash-utility.osci.io
> > To unsubscribe send an email to devel-leave(a)lists.crash-utility.osci.io
> > https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> > Contribution Guidelines:
https://github.com/crash-utility/crash/wiki
>