[Crash-utility] Re: [RESEND PATCH v1 1/1] symbols: Add support for mod symtab with combined GPL and non-GPL symbols

Tao Liu <ltao(a)redhat.com&gt; writes: > Hi Alexander, > > I'm OK with your code modifications, however I have one question, > should we deal with the new __kflagstab section introduced by the > kernel commit? I haven't dive deep into the kernel implementation, but > just curious since the *_gpl sections are removed, how should we > handle those symbols which used to belong to the section, will they be > handled within the non gpl section(so no extra code change for crash), > or handled within the new __kflagstab section(thus extra code change > for crash is needed)? Hi, in short, there is only one section __ksymtab which contains all exported symbols, GPL as well as non-GPL. And there is a new section __kflagstab which contains flags for each symbol within __ksymtab. An entry in __kflagstab indicates whether the corresponding symbol in __ksymtab is GPL or not. The cover letter explains in more details: https://lore.kernel.org/all/20260326-kflagstab-v5-0-fa0796fe88d9@google.com/ Please correct me if i'm wrong but because crash doesn't really care whether a symbol is GPL or not and because it just collects all available symbols regardless of them being GPL or not, no more changes are required in crash. Regards Alex