On Tue, May 12, 2026 at 06:29:47PM +1200, Tao Liu wrote:
Hi Huang,
Please check the following code change upon your v6, please note I haven't have the
code tested, just to illustrate my thoughts:
1) XARRAY_TYPE_PAGE_CACHE can be put into do_xarray() flags argument, so
we don't need to introduce an extra "type" argument for do_xarray(), and
the
function signature can stay unchanged.
Okay, no problem.
2) do_xarray_iter() shouldn't contain folio information, it is supposed to concern
nothing but the xarray itself. The ops->update_off() is a callback
for every xarray nodes, used as the off variable updator, within
which, you can deal with your folio case. Like I said previously,
we'd better decouple xarray iteration with folio, any special cases
are better to be handled within a callback, rather than hard code the
special cases into xarray iteration directly.
okay, I will change it in next
version.
Thanks
Huang Shijie