[Crash-utility] Re: [PATCH 1/2] Remove dead code of "BASELEVEL_REVISION"
Hi Dave,
For Patch 1 & 2, LGTM, ack.
Thanks,
Tao Liu
On Wed, Sep 9, 2026 at 3:56 PM Dave Young <yangrr.2009(a)tsinghua.org.cn> wrote:
Since commit e30a8743780a the BASELEVEL_REVISION is not used any more
Thus remove the dead code.
Signed-off-by: Dave Young <yangrr.2009(a)tsinghua.org.cn>
---
configure.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/configure.c b/configure.c
index e0626318b8d5..5eeddfe34135 100644
--- a/configure.c
+++ b/configure.c
@@ -653,24 +653,6 @@ get_release:
} else
fprintf(stderr,
"WARNING: .rh_rpm_package file does not exist!\n");
-
- if ((fp = fopen("defs.h", "r")) == NULL) {
- perror("defs.h");
- return;
- }
-
- while (fgets(buf, 512, fp)) {
- if (strncmp(buf, "#define BASELEVEL_REVISION",
- strlen("#define BASELEVEL_REVISION")) == 0) {
- p = strstr(buf, "\"") + 1;
- strip_linefeeds(p);
- p[strlen(p)-1] = '\0';
- strcpy(target_data.release, p);
- break;
- }
- }
-
- fclose(fp);
}
void
--
2.51.1