On Fri, May 31, 2024 at 5:38 PM <devel-request(a)lists.crash-utility.osci.io&gt; wrote: > > Date: Fri, 31 May 2024 17:19:37 +0800 > From: Tao Liu <ltao(a)redhat.com&gt; > Subject: [Crash-utility] [PATCH v4 14/16] x86_64: fix gdb bt for > vmware dumps > To: devel(a)lists.crash-utility.osci.io > Cc: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt;, Mahesh J > Salgaonkar <mahesh(a)linux.ibm.com&gt;, "Naveen N . Rao" > <naveen.n.rao(a)linux.vnet.ibm.com&gt;, Lianbo Jiang <lijiang(a)redhat.com&gt; > Message-ID: <20240531091939.97828-15-ltao(a)redhat.com&gt; > Content-Type: text/plain; charset=UTF-8 > > From: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt; > > vmware_vmss_get_cpu_reg() whould be called only for active tasks > to get their registers from corresponding CPUs. > Otherwise, the standard path of fetching pt_regs from the memory > (inactive_task_frame) should be used. > > Cc: Sourabh Jain <sourabhjain(a)linux.ibm.com&gt; > Cc: Hari Bathini <hbathini(a)linux.ibm.com&gt; > Cc: Mahesh J Salgaonkar <mahesh(a)linux.ibm.com&gt; > Cc: Naveen N. Rao <naveen.n.rao(a)linux.vnet.ibm.com&gt; > Cc: Lianbo Jiang <lijiang(a)redhat.com&gt; > Cc: HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com&gt; > Cc: Tao Liu <ltao(a)redhat.com&gt; > Cc: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt; > Signed-off-by: Alexey Makhalov <alexey.makhalov(a)broadcom.com&gt; > --- > x86_64.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/x86_64.c b/x86_64.c > index 47c215f..617a4ab 100644 > --- a/x86_64.c > +++ b/x86_64.c > @@ -9232,7 +9232,10 @@ x86_64_get_current_task_reg(int regno, const char *name, > if (!tc) > return FALSE; > > - if (VMSS_DUMPFILE()) > + /* > + * Task is active, grab CPU's registers > + */ > + if (is_task_active(tc->task) && VMSS_DUMPFILE()) > return vmware_vmss_get_cpu_reg(tc->processor, regno, name, size, value); > Can you try to fold this change into the [PATCH 09/16]? And add the current descriptions in the patch log.

Thanks Lianbo > BZERO(&bt_setup, sizeof(struct bt_info)); > -- > 2.40.1