5:17 p.m.
In the crash utility, the default 'ps' command (and options such as 'ps
-k')
displays kernel thread command names enclosed in square brackets
(e.g., [kworker/6:1]) to easily distinguish kernel tasks from user tasks.
However, task listing functions that rely on print_task_header() (such as
'ps -l' and 'ps -m') previously formatted all task command names enclosed
in double quotes (e.g. COMMAND: "kworker/6:1" and COMMAND: "crash").
This patch series unifies task command formatting across
print_task_header() to remove double quotes for all tasks and enclose
kernel thread command names in square brackets.
Before:
crash> ps -l 191918
[b5a7e47c0036] [ID] PID: 191918 TASK: ffff8ac62c188000 CPU: 6 COMMAND:
"kworker/6:1"
After:
crash> ps -l 191918
[b5a7e47c0036] [ID] PID: 191918 TASK: ffff8ac62c188000 CPU: 6 COMMAND:
[kworker/6:1]
Before:
crash> ps -m 196591
[0 00:00:00.033] [RU] PID: 196591 TASK: ffff8ac4bfac8000 CPU: 0 COMMAND:
"crash"
After:
crash> ps -m 196591
[0 00:00:00.033] [RU] PID: 196591 TASK: ffff8ac4bfac8000 CPU: 0 COMMAND: crash
Aaron Tomlin (2):
task: remove double quotes around command name in print_task_header()
task: enclose kernel tasks in square brackets in print_task_header()
help.c | 117 ++++++++++++++++++++++++++++-----------------------------
task.c | 7 +++-
2 files changed, 62 insertions(+), 62 deletions(-)
--
2.55.0
5:17 p.m.
New subject: [PATCH 1/2] task: remove double quotes around command name in print_task_header()
Currently, print_task_header() formats task header lines by wrapping the
command name in double quotes (e.g. COMMAND: "crash"). However, the
default output of the 'ps' command (as well as options like 'ps -k')
displays command names without double quotes.
To maintain output formatting consistency across task listings in the
crash utility, remove the double quotes surrounding command names in
print_task_header() and update the relevant command help page
documentation.
---
help.c | 117 ++++++++++++++++++++++++++++-----------------------------
task.c | 2 +-
2 files changed, 58 insertions(+), 61 deletions(-)
diff --git a/help.c b/help.c
index 79bfa5b..6b9e3d8 100644
--- a/help.c
+++ b/help.c
@@ -876,7 +876,7 @@ char *help_foreach[] = {
"\nEXAMPLES",
" Display the stack traces for all tasks:\n",
" %s> foreach bt",
-" PID: 4752 TASK: c7680000 CPU: 1 COMMAND: \"xterm\"",
+" PID: 4752 TASK: c7680000 CPU: 1 COMMAND: xterm",
" #0 [c7681edc] schedule at c01135f6",
" (void)",
" #1 [c7681f34] schedule_timeout at c01131ff",
@@ -891,7 +891,7 @@ char *help_foreach[] = {
" SS: 002b ESP: bffffadc EBP: bffffb0c ",
" CS: 0023 EIP: 402259ee ERR: 0000008e EFLAGS: 00000246 ",
" ",
-" PID: 557 TASK: c5600000 CPU: 0 COMMAND: \"nfsd\"",
+" PID: 557 TASK: c5600000 CPU: 0 COMMAND: nfsd",
" #0 [c5601f38] schedule at c01135f6",
" (void)",
" #1 [c5601f90] schedule_timeout at c01131ff",
@@ -903,7 +903,7 @@ char *help_foreach[] = {
" #4 [c65c9f24] kernel_thread at c010834f",
" (0, 0, ext2_file_inode_operations)",
" ",
-" PID: 824 TASK: c7c84000 CPU: 0 COMMAND: \"mingetty\"",
+" PID: 824 TASK: c7c84000 CPU: 0 COMMAND: mingetty",
" ...\n",
" Display the task_struct structure for each \"bash\" command:\n",
" %s> foreach bash task",
@@ -913,18 +913,18 @@ char *help_foreach[] = {
" ...\n",
" Display the state of tasks whose name contains a match to
\"event.*\":\n",
" %s> foreach 'event.*' task -R state",
-" PID: 99 TASK: ffff8804750d5500 CPU: 0 COMMAND:
\"events/0\"",
+" PID: 99 TASK: ffff8804750d5500 CPU: 0 COMMAND: events/0",
" state = 1,",
" ",
-" PID: 100 TASK: ffff8804750d4ac0 CPU: 1 COMMAND:
\"events/1\"",
+" PID: 100 TASK: ffff8804750d4ac0 CPU: 1 COMMAND: events/1",
" state = 1,",
" ",
-" PID: 101 TASK: ffff8804750d4080 CPU: 2 COMMAND:
\"events/2\"",
+" PID: 101 TASK: ffff8804750d4080 CPU: 2 COMMAND: events/2",
" state = 1,",
" ...\n",
" Display the stack traces for all blocked (TASK_UNINTERRUPTIBLE) tasks:\n",
" %s> foreach UN bt",
-" PID: 428 TASK: ffff880036b6c560 CPU: 1 COMMAND:
\"jbd2/dm-1-8\"",
+" PID: 428 TASK: ffff880036b6c560 CPU: 1 COMMAND: jbd2/dm-1-8",
" #0 [ffff880035779a70] __schedule at ffffffff815df272",
" #1 [ffff880035779b08] schedule at ffffffff815dfacf",
" #2 [ffff880035779b18] io_schedule at ffffffff815dfb7f",
@@ -1541,24 +1541,24 @@ char *help_ps[] = {
" ",
" Display the parental hierarchy of the \"%s\" process on a live
system:\n",
" %s> ps -p 4249",
-" PID: 0 TASK: c0252000 CPU: 0 COMMAND: \"swapper\"",
-" PID: 1 TASK: c009a000 CPU: 1 COMMAND: \"init\"",
-" PID: 632 TASK: c73b6000 CPU: 1 COMMAND: \"prefdm\"",
-" PID: 637 TASK: c5a4a000 CPU: 1 COMMAND: \"prefdm\"",
-" PID: 649 TASK: c179a000 CPU: 0 COMMAND: \"kwm\"",
-" PID: 683 TASK: c1164000 CPU: 0 COMMAND: \"kfm\"",
-" PID: 1186 TASK: c165a000 CPU: 0 COMMAND: \"xterm\"",
-" PID: 1188 TASK: c705e000 CPU: 1 COMMAND: \"bash\"",
-" PID: 4249 TASK: c6b9a000 CPU: 0 COMMAND:
\"crash\"",
+" PID: 0 TASK: c0252000 CPU: 0 COMMAND: swapper",
+" PID: 1 TASK: c009a000 CPU: 1 COMMAND: init",
+" PID: 632 TASK: c73b6000 CPU: 1 COMMAND: prefdm",
+" PID: 637 TASK: c5a4a000 CPU: 1 COMMAND: prefdm",
+" PID: 649 TASK: c179a000 CPU: 0 COMMAND: kwm",
+" PID: 683 TASK: c1164000 CPU: 0 COMMAND: kfm",
+" PID: 1186 TASK: c165a000 CPU: 0 COMMAND: xterm",
+" PID: 1188 TASK: c705e000 CPU: 1 COMMAND: bash",
+" PID: 4249 TASK: c6b9a000 CPU: 0 COMMAND: crash",
" ",
" Display all children of the \"kwm\" window manager:\n",
" %s> ps -c kwm",
-" PID: 649 TASK: c179a000 CPU: 0 COMMAND: \"kwm\"",
-" PID: 682 TASK: c2d58000 CPU: 1 COMMAND: \"kwmsound\"",
-" PID: 683 TASK: c1164000 CPU: 1 COMMAND: \"kfm\"",
-" PID: 685 TASK: c053c000 CPU: 0 COMMAND: \"krootwm\"",
-" PID: 686 TASK: c13fa000 CPU: 0 COMMAND: \"kpanel\"",
-" PID: 687 TASK: c13f0000 CPU: 1 COMMAND: \"kbgndwm\"",
+" PID: 649 TASK: c179a000 CPU: 0 COMMAND: kwm",
+" PID: 682 TASK: c2d58000 CPU: 1 COMMAND: kwmsound",
+" PID: 683 TASK: c1164000 CPU: 1 COMMAND: kfm",
+" PID: 685 TASK: c053c000 CPU: 0 COMMAND: krootwm",
+" PID: 686 TASK: c13fa000 CPU: 0 COMMAND: kpanel",
+" PID: 687 TASK: c13f0000 CPU: 1 COMMAND: kbgndwm",
" ",
" Display all threads in a firefox session:\n",
" %s> ps firefox",
@@ -1581,7 +1581,7 @@ char *help_ps[] = {
" ",
" Show the time usage data for pid 10318:\n",
" %s> ps -t 10318",
-" PID: 10318 TASK: f7b85550 CPU: 5 COMMAND: \"bash\"",
+" PID: 10318 TASK: f7b85550 CPU: 5 COMMAND: bash",
" RUN TIME: 1 days, 01:35:32",
" START TIME: 5209",
" UTIME: 95",
@@ -1639,53 +1639,50 @@ char *help_ps[] = {
" Show all tasks sorted by their task_struct's last_run, timestamp, or",
" sched_entity last_arrival timestamp value, whichever applies:\n",
" %s> ps -l",
-" [20811245123] [IN] PID: 37 TASK: f7153030 CPU: 2 COMMAND:
\"events/2\"",
-" [20811229959] [IN] PID: 1756 TASK: f2a5a570 CPU: 2 COMMAND:
\"ntpd\"",
-" [20800696644] [IN] PID: 1456 TASK: f2b1f030 CPU: 4 COMMAND:
\"irqbalance\"",
-" [20617047229] [IN] PID: 2324 TASK: f57f9570 CPU: 5 COMMAND:
\"flush-253:0\"",
-" [20617029209] [IN] PID: 49 TASK: f7167030 CPU: 4 COMMAND:
\"bdi-default\"",
-" [20438025365] [IN] PID: 345 TASK: f55c7ab0 CPU: 3 COMMAND:
\"mpt_poll_0\"",
-" [20103026046] [IN] PID: 728 TASK: f72ba570 CPU: 3 COMMAND:
\"edac-poller\"",
-" [20000189409] [IN] PID: 35 TASK: f7153ab0 CPU: 0 COMMAND:
\"events/0\"",
-" [20000179905] [IN] PID: 48 TASK: f7167570 CPU: 0 COMMAND:
\"sync_supers\"",
-" [19997120354] [IN] PID: 36 TASK: f7153570 CPU: 1 COMMAND:
\"events/1\"",
-" [19991059209] [IN] PID: 38 TASK: f715fab0 CPU: 3 COMMAND:
\"events/3\"",
-" [19988091608] [IN] PID: 39 TASK: f715f570 CPU: 4 COMMAND:
\"events/4\"",
-" [19985076530] [IN] PID: 40 TASK: f715f030 CPU: 5 COMMAND:
\"events/5\"",
-" [19982019106] [IN] PID: 41 TASK: f7161ab0 CPU: 6 COMMAND:
\"events/6\"",
-" [19982016294] [IN] PID: 29 TASK: f7109ab0 CPU: 6 COMMAND:
\"ksoftirqd/6\"",
-" [19838402345] [RU] PID: 2331 TASK: f297f570 CPU: 7 COMMAND:
\"bash\"",
-" [19837129436] [IN] PID: 2326 TASK: f2ad5030 CPU: 6 COMMAND:
\"sshd\"",
-" [19289476417] [IN] PID: 1772 TASK: f5665570 CPU: 5 COMMAND:
\"sendmail\"",
+" [20811245123] [IN] PID: 37 TASK: f7153030 CPU: 2 COMMAND: events/2",
+" [20811229959] [IN] PID: 1756 TASK: f2a5a570 CPU: 2 COMMAND: ntpd",
+" [20800696644] [IN] PID: 1456 TASK: f2b1f030 CPU: 4 COMMAND:
irqbalance",
+" [20617047229] [IN] PID: 2324 TASK: f57f9570 CPU: 5 COMMAND:
flush-253:0",
+" [20617029209] [IN] PID: 49 TASK: f7167030 CPU: 4 COMMAND:
bdi-default",
+" [20438025365] [IN] PID: 345 TASK: f55c7ab0 CPU: 3 COMMAND:
mpt_poll_0",
+" [20103026046] [IN] PID: 728 TASK: f72ba570 CPU: 3 COMMAND:
edac-poller",
+" [20000189409] [IN] PID: 35 TASK: f7153ab0 CPU: 0 COMMAND: events/0",
+" [20000179905] [IN] PID: 48 TASK: f7167570 CPU: 0 COMMAND:
sync_supers",
+" [19997120354] [IN] PID: 36 TASK: f7153570 CPU: 1 COMMAND: events/1",
+" [19991059209] [IN] PID: 38 TASK: f715fab0 CPU: 3 COMMAND: events/3",
+" [19988091608] [IN] PID: 39 TASK: f715f570 CPU: 4 COMMAND: events/4",
+" [19985076530] [IN] PID: 40 TASK: f715f030 CPU: 5 COMMAND: events/5",
+" [19982019106] [IN] PID: 41 TASK: f7161ab0 CPU: 6 COMMAND: events/6",
+" [19982016294] [IN] PID: 29 TASK: f7109ab0 CPU: 6 COMMAND:
ksoftirqd/6",
+" [19838402345] [RU] PID: 2331 TASK: f297f570 CPU: 7 COMMAND: bash",
+" [19837129436] [IN] PID: 2326 TASK: f2ad5030 CPU: 6 COMMAND: sshd",
+" [19289476417] [IN] PID: 1772 TASK: f5665570 CPU: 5 COMMAND: sendmail",
" ...\n",
" Show the most-recently run tasks on cpu 0 using both the -l and the -m",
" options:\n",
" %s> ps -m -C0",
" CPU: 0",
-" [ 0 00:00:00.003] [RU] PID: 1205 TASK: dee03f20 CPU: 0 COMMAND:
\"insmod\"",
-" [ 0 00:00:00.006] [RU] PID: 770 TASK: df9e9940 CPU: 0 COMMAND:
\"rsyslogd\"",
-" [ 0 00:00:00.009] [IN] PID: 603 TASK: df9bcbc0 CPU: 0 COMMAND:
\"udevd\"",
-" [ 0 00:00:00.010] [IN] PID: 348 TASK: df9ecbc0 CPU: 0 COMMAND:
\"udevd\"",
-" [ 0 00:00:00.013] [IN] PID: 934 TASK: df9171a0 CPU: 0 COMMAND:
\"hald\"",
-" [ 0 00:00:00.023] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
\"events/0\"",
-" [ 0 00:00:00.029] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
\"kblockd/0\"",
-" [ 0 00:00:00.101] [IN] PID: 1168 TASK: dee01940 CPU: 0 COMMAND:
\"bash\"",
-" [ 0 00:00:01.404] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
\"flush-8:0\"",
+" [ 0 00:00:00.003] [RU] PID: 1205 TASK: dee03f20 CPU: 0 COMMAND: insmod",
+" [ 0 00:00:00.006] [RU] PID: 770 TASK: df9e9940 CPU: 0 COMMAND:
rsyslogd",
+" [ 0 00:00:00.009] [IN] PID: 603 TASK: df9bcbc0 CPU: 0 COMMAND: udevd",
+" [ 0 00:00:00.010] [IN] PID: 348 TASK: df9ecbc0 CPU: 0 COMMAND: udevd",
+" [ 0 00:00:00.013] [IN] PID: 934 TASK: df9171a0 CPU: 0 COMMAND: hald",
+" [ 0 00:00:00.023] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
events/0",
+" [ 0 00:00:00.029] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
kblockd/0",
+" [ 0 00:00:00.101] [IN] PID: 1168 TASK: dee01940 CPU: 0 COMMAND: bash",
+" [ 0 00:00:01.404] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
flush-8:0",
" ...",
" ",
" %s> ps -l -C0",
" CPU: 0",
-" [137146164748] [RU] PID: 1205 TASK: dee03f20 CPU: 0 COMMAND:
\"insmod\"",
-" [137142534372] [RU] PID: 770 TASK: df9e9940 CPU: 0 COMMAND:
\"rsyslogd\"",
-" [137140168469] [IN] PID: 603 TASK: df9bcbc0 CPU: 0 COMMAND:
\"udevd\"",
-" [137138826427] [IN] PID: 348 TASK: df9ecbc0 CPU: 0 COMMAND:
\"udevd\"",
-" [137135214599] [IN] PID: 934 TASK: df9171a0 CPU: 0 COMMAND:
\"hald\"",
-" [137125651275] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
\"events/0\"",
-" [137119564815] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
\"kblockd/0\"",
-" [137047715027] [IN] PID: 1168 TASK: dee01940 CPU: 0 COMMAND:
\"bash\"",
-" [135744209052] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
\"flush-8:0\"",
+" [137140168469] [IN] PID: 603 TASK: df9bcbc0 CPU: 0 COMMAND: udevd",
+" [137138826427] [IN] PID: 348 TASK: df9ecbc0 CPU: 0 COMMAND: udevd",
+" [137135214599] [IN] PID: 934 TASK: df9171a0 CPU: 0 COMMAND: hald",
+" [137125651275] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND: events/0",
+" [137119564815] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND: kblockd/0",
+" [137047715027] [IN] PID: 1168 TASK: dee01940 CPU: 0 COMMAND: bash",
+" [135744209052] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND: flush-8:0",
" ... ",
-
" ",
" Show the kernel stack pointer of each user task:\n",
" %s> ps -us",
diff --git a/task.c b/task.c
index a411876..5c33c4a 100644
--- a/task.c
+++ b/task.c
@@ -7808,7 +7808,7 @@ print_task_header(FILE *out, struct task_context *tc, int newline)
char buf[BUFSIZE];
char buf1[BUFSIZE];
- fprintf(out, "%sPID: %-7ld TASK: %s CPU: %-3s COMMAND:
\"%s\"\n",
+ fprintf(out, "%sPID: %-7ld TASK: %s CPU: %-3s COMMAND: %s\n",
newline ? "\n" : "", tc->pid,
mkstring(buf1, VADDR_PRLEN, LJUST|LONG_HEX, MKSTR(tc->task)),
task_cpu(tc->processor, buf, !VERBOSE), tc->comm);
--
2.55.0
5:17 p.m.
New subject: [PATCH 2/2] task: enclose kernel tasks in square brackets in print_task_header()
In the crash utility, the default output of the 'ps' command (as well as
options such as 'ps -k') displays kernel thread command names enclosed
in square brackets (e.g. [kworker/6:1]) to easily distinguish kernel
tasks from user tasks.
However, task listing options that rely on print_task_header() (such as
'ps -l' and 'ps -m') previously displayed kernel task command names
without square brackets (e.g. COMMAND: kworker/6:1).
To maintain consistency across all 'ps' command options, update
print_task_header() to check if a task is a kernel thread via
is_kernel_thread() and enclose its command name in square brackets. Also
update the corresponding help page examples to reflect this formatting.
---
help.c | 42 +++++++++++++++++++++---------------------
task.c | 7 +++++--
2 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/help.c b/help.c
index 6b9e3d8..09cab73 100644
--- a/help.c
+++ b/help.c
@@ -913,18 +913,18 @@ char *help_foreach[] = {
" ...\n",
" Display the state of tasks whose name contains a match to
\"event.*\":\n",
" %s> foreach 'event.*' task -R state",
-" PID: 99 TASK: ffff8804750d5500 CPU: 0 COMMAND: events/0",
+" PID: 99 TASK: ffff8804750d5500 CPU: 0 COMMAND: [events/0]",
" state = 1,",
" ",
-" PID: 100 TASK: ffff8804750d4ac0 CPU: 1 COMMAND: events/1",
+" PID: 100 TASK: ffff8804750d4ac0 CPU: 1 COMMAND: [events/1]",
" state = 1,",
" ",
-" PID: 101 TASK: ffff8804750d4080 CPU: 2 COMMAND: events/2",
+" PID: 101 TASK: ffff8804750d4080 CPU: 2 COMMAND: [events/2]",
" state = 1,",
" ...\n",
" Display the stack traces for all blocked (TASK_UNINTERRUPTIBLE) tasks:\n",
" %s> foreach UN bt",
-" PID: 428 TASK: ffff880036b6c560 CPU: 1 COMMAND: jbd2/dm-1-8",
+" PID: 428 TASK: ffff880036b6c560 CPU: 1 COMMAND: [jbd2/dm-1-8]",
" #0 [ffff880035779a70] __schedule at ffffffff815df272",
" #1 [ffff880035779b08] schedule at ffffffff815dfacf",
" #2 [ffff880035779b18] io_schedule at ffffffff815dfb7f",
@@ -1541,7 +1541,7 @@ char *help_ps[] = {
" ",
" Display the parental hierarchy of the \"%s\" process on a live
system:\n",
" %s> ps -p 4249",
-" PID: 0 TASK: c0252000 CPU: 0 COMMAND: swapper",
+" PID: 0 TASK: c0252000 CPU: 0 COMMAND: [swapper]",
" PID: 1 TASK: c009a000 CPU: 1 COMMAND: init",
" PID: 632 TASK: c73b6000 CPU: 1 COMMAND: prefdm",
" PID: 637 TASK: c5a4a000 CPU: 1 COMMAND: prefdm",
@@ -1639,21 +1639,21 @@ char *help_ps[] = {
" Show all tasks sorted by their task_struct's last_run, timestamp, or",
" sched_entity last_arrival timestamp value, whichever applies:\n",
" %s> ps -l",
-" [20811245123] [IN] PID: 37 TASK: f7153030 CPU: 2 COMMAND: events/2",
+" [20811245123] [IN] PID: 37 TASK: f7153030 CPU: 2 COMMAND:
[events/2]",
" [20811229959] [IN] PID: 1756 TASK: f2a5a570 CPU: 2 COMMAND: ntpd",
" [20800696644] [IN] PID: 1456 TASK: f2b1f030 CPU: 4 COMMAND:
irqbalance",
-" [20617047229] [IN] PID: 2324 TASK: f57f9570 CPU: 5 COMMAND:
flush-253:0",
-" [20617029209] [IN] PID: 49 TASK: f7167030 CPU: 4 COMMAND:
bdi-default",
-" [20438025365] [IN] PID: 345 TASK: f55c7ab0 CPU: 3 COMMAND:
mpt_poll_0",
-" [20103026046] [IN] PID: 728 TASK: f72ba570 CPU: 3 COMMAND:
edac-poller",
-" [20000189409] [IN] PID: 35 TASK: f7153ab0 CPU: 0 COMMAND: events/0",
-" [20000179905] [IN] PID: 48 TASK: f7167570 CPU: 0 COMMAND:
sync_supers",
-" [19997120354] [IN] PID: 36 TASK: f7153570 CPU: 1 COMMAND: events/1",
-" [19991059209] [IN] PID: 38 TASK: f715fab0 CPU: 3 COMMAND: events/3",
-" [19988091608] [IN] PID: 39 TASK: f715f570 CPU: 4 COMMAND: events/4",
-" [19985076530] [IN] PID: 40 TASK: f715f030 CPU: 5 COMMAND: events/5",
-" [19982019106] [IN] PID: 41 TASK: f7161ab0 CPU: 6 COMMAND: events/6",
-" [19982016294] [IN] PID: 29 TASK: f7109ab0 CPU: 6 COMMAND:
ksoftirqd/6",
+" [20617047229] [IN] PID: 2324 TASK: f57f9570 CPU: 5 COMMAND:
[flush-253:0]",
+" [20617029209] [IN] PID: 49 TASK: f7167030 CPU: 4 COMMAND:
[bdi-default]",
+" [20438025365] [IN] PID: 345 TASK: f55c7ab0 CPU: 3 COMMAND:
[mpt_poll_0]",
+" [20103026046] [IN] PID: 728 TASK: f72ba570 CPU: 3 COMMAND:
[edac-poller]",
+" [20000189409] [IN] PID: 35 TASK: f7153ab0 CPU: 0 COMMAND:
[events/0]",
+" [20000179905] [IN] PID: 48 TASK: f7167570 CPU: 0 COMMAND:
[sync_supers]",
+" [19997120354] [IN] PID: 36 TASK: f7153570 CPU: 1 COMMAND:
[events/1]",
+" [19991059209] [IN] PID: 38 TASK: f715fab0 CPU: 3 COMMAND:
[events/3]",
+" [19988091608] [IN] PID: 39 TASK: f715f570 CPU: 4 COMMAND:
[events/4]",
+" [19985076530] [IN] PID: 40 TASK: f715f030 CPU: 5 COMMAND:
[events/5]",
+" [19982019106] [IN] PID: 41 TASK: f7161ab0 CPU: 6 COMMAND:
[events/6]",
+" [19982016294] [IN] PID: 29 TASK: f7109ab0 CPU: 6 COMMAND:
[ksoftirqd/6]",
" [19838402345] [RU] PID: 2331 TASK: f297f570 CPU: 7 COMMAND: bash",
" [19837129436] [IN] PID: 2326 TASK: f2ad5030 CPU: 6 COMMAND: sshd",
" [19289476417] [IN] PID: 1772 TASK: f5665570 CPU: 5 COMMAND: sendmail",
@@ -1667,10 +1667,10 @@ char *help_ps[] = {
" [ 0 00:00:00.009] [IN] PID: 603 TASK: df9bcbc0 CPU: 0 COMMAND: udevd",
" [ 0 00:00:00.010] [IN] PID: 348 TASK: df9ecbc0 CPU: 0 COMMAND: udevd",
" [ 0 00:00:00.013] [IN] PID: 934 TASK: df9171a0 CPU: 0 COMMAND: hald",
-" [ 0 00:00:00.023] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
events/0",
-" [ 0 00:00:00.029] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
kblockd/0",
+" [ 0 00:00:00.023] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
[events/0]",
+" [ 0 00:00:00.029] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
[kblockd/0]",
" [ 0 00:00:00.101] [IN] PID: 1168 TASK: dee01940 CPU: 0 COMMAND: bash",
-" [ 0 00:00:01.404] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
flush-8:0",
+" [ 0 00:00:01.404] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
[flush-8:0]",
" ...",
" ",
" %s> ps -l -C0",
diff --git a/task.c b/task.c
index 5c33c4a..b1b2fde 100644
--- a/task.c
+++ b/task.c
@@ -7808,10 +7808,13 @@ print_task_header(FILE *out, struct task_context *tc, int
newline)
char buf[BUFSIZE];
char buf1[BUFSIZE];
- fprintf(out, "%sPID: %-7ld TASK: %s CPU: %-3s COMMAND: %s\n",
+ fprintf(out, "%sPID: %-7ld TASK: %s CPU: %-3s COMMAND: %s%s%s\n",
newline ? "\n" : "", tc->pid,
mkstring(buf1, VADDR_PRLEN, LJUST|LONG_HEX, MKSTR(tc->task)),
- task_cpu(tc->processor, buf, !VERBOSE), tc->comm);
+ task_cpu(tc->processor, buf, !VERBOSE),
+ is_kernel_thread(tc->task) ? "[" : "",
+ tc->comm,
+ is_kernel_thread(tc->task) ? "]" : "");
}
/*
--
2.55.0
3:30 a.m.
New subject: [PATCH 2/2] task: enclose kernel tasks in square brackets in print_task_header()
Hi Aaron,
I cannot apply your patch, all of the command names are double quoted in my local tree,
anything wrong?
On 8/3/26 6:17 AM, Aaron Tomlin wrote:
> In the crash utility, the default output of the 'ps' command (as well as
> options such as 'ps -k') displays kernel thread command names enclosed
> in square brackets (e.g. [kworker/6:1]) to easily distinguish kernel
> tasks from user tasks.
>
> However, task listing options that rely on print_task_header() (such as
> 'ps -l' and 'ps -m') previously displayed kernel task command names
> without square brackets (e.g. COMMAND: kworker/6:1).
>
> To maintain consistency across all 'ps' command options, update
> print_task_header() to check if a task is a kernel thread via
> is_kernel_thread() and enclose its command name in square brackets. Also
> update the corresponding help page examples to reflect this formatting.
> ---
> help.c | 42 +++++++++++++++++++++---------------------
> task.c | 7 +++++--
> 2 files changed, 26 insertions(+), 23 deletions(-)
>
> diff --git a/help.c b/help.c
> index 6b9e3d8..09cab73 100644
> --- a/help.c
> +++ b/help.c
> @@ -913,18 +913,18 @@ char *help_foreach[] = {
> " ...\n",
> " Display the state of tasks whose name contains a match to
\"event.*\":\n",
> " %s> foreach 'event.*' task -R state",
> -" PID: 99 TASK: ffff8804750d5500 CPU: 0 COMMAND: events/0",
> +" PID: 99 TASK: ffff8804750d5500 CPU: 0 COMMAND: [events/0]",
> " state = 1,",
> " ",
> -" PID: 100 TASK: ffff8804750d4ac0 CPU: 1 COMMAND: events/1",
> +" PID: 100 TASK: ffff8804750d4ac0 CPU: 1 COMMAND: [events/1]",
> " state = 1,",
> " ",
> -" PID: 101 TASK: ffff8804750d4080 CPU: 2 COMMAND: events/2",
> +" PID: 101 TASK: ffff8804750d4080 CPU: 2 COMMAND: [events/2]",
> " state = 1,",
> " ...\n",
> " Display the stack traces for all blocked (TASK_UNINTERRUPTIBLE)
tasks:\n",
> " %s> foreach UN bt",
> -" PID: 428 TASK: ffff880036b6c560 CPU: 1 COMMAND: jbd2/dm-1-8",
> +" PID: 428 TASK: ffff880036b6c560 CPU: 1 COMMAND:
[jbd2/dm-1-8]",
> " #0 [ffff880035779a70] __schedule at ffffffff815df272",
> " #1 [ffff880035779b08] schedule at ffffffff815dfacf",
> " #2 [ffff880035779b18] io_schedule at ffffffff815dfb7f",
> @@ -1541,7 +1541,7 @@ char *help_ps[] = {
> " ",
> " Display the parental hierarchy of the \"%s\" process on a live
system:\n",
> " %s> ps -p 4249",
> -" PID: 0 TASK: c0252000 CPU: 0 COMMAND: swapper",
> +" PID: 0 TASK: c0252000 CPU: 0 COMMAND: [swapper]",
> " PID: 1 TASK: c009a000 CPU: 1 COMMAND: init",
> " PID: 632 TASK: c73b6000 CPU: 1 COMMAND: prefdm",
> " PID: 637 TASK: c5a4a000 CPU: 1 COMMAND: prefdm",
> @@ -1639,21 +1639,21 @@ char *help_ps[] = {
> " Show all tasks sorted by their task_struct's last_run, timestamp,
or",
> " sched_entity last_arrival timestamp value, whichever applies:\n",
> " %s> ps -l",
> -" [20811245123] [IN] PID: 37 TASK: f7153030 CPU: 2 COMMAND:
events/2",
> +" [20811245123] [IN] PID: 37 TASK: f7153030 CPU: 2 COMMAND:
[events/2]",
> " [20811229959] [IN] PID: 1756 TASK: f2a5a570 CPU: 2 COMMAND:
ntpd",
> " [20800696644] [IN] PID: 1456 TASK: f2b1f030 CPU: 4 COMMAND:
irqbalance",
> -" [20617047229] [IN] PID: 2324 TASK: f57f9570 CPU: 5 COMMAND:
flush-253:0",
> -" [20617029209] [IN] PID: 49 TASK: f7167030 CPU: 4 COMMAND:
bdi-default",
> -" [20438025365] [IN] PID: 345 TASK: f55c7ab0 CPU: 3 COMMAND:
mpt_poll_0",
> -" [20103026046] [IN] PID: 728 TASK: f72ba570 CPU: 3 COMMAND:
edac-poller",
> -" [20000189409] [IN] PID: 35 TASK: f7153ab0 CPU: 0 COMMAND:
events/0",
> -" [20000179905] [IN] PID: 48 TASK: f7167570 CPU: 0 COMMAND:
sync_supers",
> -" [19997120354] [IN] PID: 36 TASK: f7153570 CPU: 1 COMMAND:
events/1",
> -" [19991059209] [IN] PID: 38 TASK: f715fab0 CPU: 3 COMMAND:
events/3",
> -" [19988091608] [IN] PID: 39 TASK: f715f570 CPU: 4 COMMAND:
events/4",
> -" [19985076530] [IN] PID: 40 TASK: f715f030 CPU: 5 COMMAND:
events/5",
> -" [19982019106] [IN] PID: 41 TASK: f7161ab0 CPU: 6 COMMAND:
events/6",
> -" [19982016294] [IN] PID: 29 TASK: f7109ab0 CPU: 6 COMMAND:
ksoftirqd/6",
> +" [20617047229] [IN] PID: 2324 TASK: f57f9570 CPU: 5 COMMAND:
[flush-253:0]",
> +" [20617029209] [IN] PID: 49 TASK: f7167030 CPU: 4 COMMAND:
[bdi-default]",
> +" [20438025365] [IN] PID: 345 TASK: f55c7ab0 CPU: 3 COMMAND:
[mpt_poll_0]",
> +" [20103026046] [IN] PID: 728 TASK: f72ba570 CPU: 3 COMMAND:
[edac-poller]",
> +" [20000189409] [IN] PID: 35 TASK: f7153ab0 CPU: 0 COMMAND:
[events/0]",
> +" [20000179905] [IN] PID: 48 TASK: f7167570 CPU: 0 COMMAND:
[sync_supers]",
> +" [19997120354] [IN] PID: 36 TASK: f7153570 CPU: 1 COMMAND:
[events/1]",
> +" [19991059209] [IN] PID: 38 TASK: f715fab0 CPU: 3 COMMAND:
[events/3]",
> +" [19988091608] [IN] PID: 39 TASK: f715f570 CPU: 4 COMMAND:
[events/4]",
> +" [19985076530] [IN] PID: 40 TASK: f715f030 CPU: 5 COMMAND:
[events/5]",
> +" [19982019106] [IN] PID: 41 TASK: f7161ab0 CPU: 6 COMMAND:
[events/6]",
> +" [19982016294] [IN] PID: 29 TASK: f7109ab0 CPU: 6 COMMAND:
[ksoftirqd/6]",
> " [19838402345] [RU] PID: 2331 TASK: f297f570 CPU: 7 COMMAND:
bash",
> " [19837129436] [IN] PID: 2326 TASK: f2ad5030 CPU: 6 COMMAND:
sshd",
> " [19289476417] [IN] PID: 1772 TASK: f5665570 CPU: 5 COMMAND:
sendmail",
> @@ -1667,10 +1667,10 @@ char *help_ps[] = {
> " [ 0 00:00:00.009] [IN] PID: 603 TASK: df9bcbc0 CPU: 0 COMMAND:
udevd",
> " [ 0 00:00:00.010] [IN] PID: 348 TASK: df9ecbc0 CPU: 0 COMMAND:
udevd",
> " [ 0 00:00:00.013] [IN] PID: 934 TASK: df9171a0 CPU: 0 COMMAND:
hald",
> -" [ 0 00:00:00.023] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
events/0",
> -" [ 0 00:00:00.029] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
kblockd/0",
> +" [ 0 00:00:00.023] [IN] PID: 6 TASK: df443f20 CPU: 0 COMMAND:
[events/0]",
> +" [ 0 00:00:00.029] [IN] PID: 15 TASK: df46b280 CPU: 0 COMMAND:
[kblockd/0]",
> " [ 0 00:00:00.101] [IN] PID: 1168 TASK: dee01940 CPU: 0 COMMAND:
bash",
> -" [ 0 00:00:01.404] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
flush-8:0",
> +" [ 0 00:00:01.404] [IN] PID: 272 TASK: dfa48ca0 CPU: 0 COMMAND:
[flush-8:0]",
> " ...",
> " ",
> " %s> ps -l -C0",
> diff --git a/task.c b/task.c
> index 5c33c4a..b1b2fde 100644
> --- a/task.c
> +++ b/task.c
> @@ -7808,10 +7808,13 @@ print_task_header(FILE *out, struct task_context *tc, int
newline)
> char buf[BUFSIZE];
> char buf1[BUFSIZE];
>
> - fprintf(out, "%sPID: %-7ld TASK: %s CPU: %-3s COMMAND: %s\n",
> + fprintf(out, "%sPID: %-7ld TASK: %s CPU: %-3s COMMAND:
%s%s%s\n",
> newline ? "\n" : "", tc->pid,
> mkstring(buf1, VADDR_PRLEN, LJUST|LONG_HEX, MKSTR(tc->task)),
> - task_cpu(tc->processor, buf, !VERBOSE), tc->comm);
> + task_cpu(tc->processor, buf, !VERBOSE),
> + is_kernel_thread(tc->task) ? "[" : "",
> + tc->comm,
> + is_kernel_thread(tc->task) ? "]" : "");
> }
>
> /*
12:36 p.m.
New subject: [PATCH 2/2] task: enclose kernel tasks in square brackets in print_task_header()
On Thu, Aug 06, 2026 at 04:30:22PM +0800, Dave Young wrote:
Hi Aaron,
I cannot apply your patch, all of the command names are double quoted in my local tree,
anything wrong?
Hi Dave,
Thank you for attempting to apply these changes.
Please note removing double quotes (i.e., PATCH 1/2) is an intentional
prerequisite change. Do you attempt to apply this patch first?
Kind regards,
--
Aaron Tomlin
3:47 a.m.
New subject: [PATCH 2/2] task: enclose kernel tasks in square brackets in print_task_header()
Hi,
On 8/7/26 1:36 AM, Aaron Tomlin wrote:
On Thu, Aug 06, 2026 at 04:30:22PM +0800, Dave Young wrote:
> Hi Aaron,
>
> I cannot apply your patch, all of the command names are double quoted in my local
tree, anything wrong?
Hi Dave,
Thank you for attempting to apply these changes.
Please note removing double quotes (i.e., PATCH 1/2) is an intentional
prerequisite change. Do you attempt to apply this patch first?
Oops, I did not see it, I need more time to get familar with the new email client.
Replacing with '[' for kernel threads is good but not something important. It
seems there are more places using the quotes, not only those your replaced in your patch
1/2. I would suggest you to only do minimal changes for kernel threads.
>
>
> Kind regards,
3:02 p.m.
New subject: [PATCH 2/2] task: enclose kernel tasks in square brackets in print_task_header()
On Fri, Aug 07, 2026 at 04:47:09PM +0800, Dave Young wrote:
Hi,
On 8/7/26 1:36 AM, Aaron Tomlin wrote:
> On Thu, Aug 06, 2026 at 04:30:22PM +0800, Dave Young wrote:
>> Hi Aaron,
>>
>> I cannot apply your patch, all of the command names are double quoted in my
local tree, anything wrong?
>
> Hi Dave,
>
> Thank you for attempting to apply these changes.
>
> Please note removing double quotes (i.e., PATCH 1/2) is an intentional
> prerequisite change. Do you attempt to apply this patch first?
Oops, I did not see it, I need more time to get familar with the new
email client.
Ho problem!
Replacing with '[' for kernel threads is good but not
something
important. It seems there are more places using the quotes, not only
those your replaced in your patch 1/2. I would suggest you to only do
minimal changes for kernel threads.
I agree. It is certaintly not important. I use it locally to keep the 'ps'
command consistent; all other built-in crash commands (e.g., 'runq') was
intentionally excluded.
Kind regards,
--
Aaron Tomlin
15
days inactive
20
days old
devel@lists.crash-utility.osci.io
6 comments
2 participants
participants (2)
-
Aaron Tomlin -
Dave Young