[Crash-utility] Re: [PATCH 2/2] task: enclose kernel tasks in square brackets in print_task_header()
On Fri, Aug 07, 2026 at 04:47:09PM +0800, Dave Young wrote:
Hi,
On 8/7/26 1:36 AM, Aaron Tomlin wrote:
> On Thu, Aug 06, 2026 at 04:30:22PM +0800, Dave Young wrote:
>> Hi Aaron,
>>
>> I cannot apply your patch, all of the command names are double quoted in my
local tree, anything wrong?
>
> Hi Dave,
>
> Thank you for attempting to apply these changes.
>
> Please note removing double quotes (i.e., PATCH 1/2) is an intentional
> prerequisite change. Do you attempt to apply this patch first?
Oops, I did not see it, I need more time to get familar with the new
email client.
Ho problem!
Replacing with '[' for kernel threads is good but not
something
important. It seems there are more places using the quotes, not only
those your replaced in your patch 1/2. I would suggest you to only do
minimal changes for kernel threads.
I agree. It is certaintly not important. I use it locally to keep the 'ps'
command consistent; all other built-in crash commands (e.g., 'runq') was
intentionally excluded.
Kind regards,
--
Aaron Tomlin